Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incremental TS strict - #3183

Open
snowystinger opened this issue May 31, 2022 · 0 comments
Open

Incremental TS strict - #3183

snowystinger opened this issue May 31, 2022 · 0 comments
Labels
help wanted Extra attention is needed typescript

Comments

@snowystinger
Copy link
Member

snowystinger commented May 31, 2022 •
edited by yihuiliao
Loading

🙋 Feature Request

It's been determined that as a library, we cannot be anything other than strict because that affects everyone who uses our library. We're taking an incremental approach to this, built off #3143 which did button.
Below is all of our packages. We should be able to turn this on for each one, a few at a time, so it isn't too disruptive.

Note: as we do more of these, we may fix it in other packages, that we are explicitly working on. It may be easiest to start with a React Spectrum component and turn that on. But that might be too much all at once, so you could turn it on for some hooks first to incrementally tackle a bigger component.

List of packages to update :

./packages/@adobe/:

  • react-spectrum - no errors
  • spectrum-css-temp - no errors

./packages/@internationalized/:

./packages/@react-aria/:

./packages/@react-spectrum/:

./packages/@react-stately/:

./packages/@react-types/:

./packages/@spectrum-icons - #5568

  • build-tools - no errors
  • color - no errors
  • illustrations - no errors
  • ui - no errors
  • workflow - no errors
  • packages/react-aria - no errors
  • packages/react-stately - no errors

./packages/react-aria-components - no errors

🧢 Your Company/Team

RSP
@snowystinger snowystinger mentioned this issue Jul 20, 2022
Closed
@matthewdeutsch matthewdeutsch changed the title Incremental TS strict Incremental TS strict - [component] Oct 24, 2022
@matthewdeutsch matthewdeutsch changed the title Incremental TS strict - [component] Incremental TS strict - Button/ButtonGroup Nov 9, 2022
@matthewdeutsch matthewdeutsch changed the title Incremental TS strict - Button/ButtonGroup Incremental TS strict - Nov 23, 2022
@LFDanLu LFDanLu mentioned this issue Nov 28, 2022
Closed
@reidbarber reidbarber mentioned this issue Jan 13, 2023
Closed
@LFDanLu LFDanLu mentioned this issue Apr 11, 2023
Closed
@LFDanLu LFDanLu mentioned this issue Jul 18, 2023
Closed
@LFDanLu LFDanLu mentioned this issue Sep 1, 2023
Closed
@reidbarber reidbarber mentioned this issue Sep 29, 2023
Closed
@yihuiliao yihuiliao mentioned this issue Oct 12, 2023
Closed
@ryo-manba ryo-manba mentioned this issue Nov 23, 2023
Merged
5 tasks
This was referenced Dec 12, 2023
Merged
Merged
@m5r m5r mentioned this issue Jan 3, 2024
Open
6 tasks
This was referenced Feb 13, 2024
Merged
Closed
@ishank-s ishank-s mentioned this issue Apr 7, 2024
Open
5 tasks
@snowystinger snowystinger mentioned this issue May 8, 2024
Closed
@snowystinger snowystinger mentioned this issue Jun 19, 2024
Merged
5 tasks
@snowystinger snowystinger mentioned this issue Jul 26, 2024
Open
@dannify dannify added the help wanted Extra attention is needed label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed typescript
Projects
RSP Component Milestones
Status: 📋 Waiting for Sprint
Milestone
No milestone
Development

No branches or pull requests
3 participants
@snowystinger @LFDanLu @dannify