Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Custom Business Calendars to the Datepicker/Calendar #3270

Open
michayou opened this issue Jun 27, 2022 · 0 comments
Open

Allow Custom Business Calendars to the Datepicker/Calendar #3270

michayou opened this issue Jun 27, 2022 · 0 comments
Labels
rsp:DatePicker spectrum design waiting for spectrum design

Comments

@michayou
Copy link
Contributor

michayou commented Jun 27, 2022

🙋 Feature Request

There are a number of custom calendars supported by Analytics Workspace that are not supported by the react spectrum calendar controls. These include:

  • 445
  • 454
  • 544
  • NRF
  • QRS
  • Modified Gregorian

Here's a wikipedia link to one of them that explains more: https://en.wikipedia.org/wiki/4%E2%80%934%E2%80%935_calendar

Right now, the spectrum calendar only supports the Gregorian calendar, but we cannot use it in our app until it supports all the special calendars.

🤔 Expected Behavior

The most flexible way would be to allow the developer to specify the calendar details to the date range picker. The second best way would be to have something like calendar={"NRF"} as one of the parameters.

😯 Current Behavior

Currently the calendar only supports the Gregorian calendar, which is not sufficient for a business analytics app.

💁 Possible Solution

Analytics Workspace (and Report Builder) have written custom calendar controls that that the calendar type as an input and produce the correct calendar display. You can see it in the report builder code base.

🔦 Context

Report builder allows customers to create reports within Microsoft Excel using their data from Analytics Workspace. Some companies use custom calendars and we need to also use those calendars for determining the start and end dates of when we should gather the data. We cannot do that using the react spectrum components.

💻 Examples

Here is an example of a custom calendar for the month of August
Screen Shot 2022-06-24 at 2 02 09 PM

You can see this calendar in action in Analytics Workspace by using the company OBU ENG SC and the report suite Geometrixx A4T

🧢 Your Company/Team

Adobe/Report Builder under the Client Apps team.

🎁 Tracking Ticket (optional)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rsp:DatePicker spectrum design waiting for spectrum design
Projects
None yet
Development

No branches or pull requests

3 participants