Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider Down state #1583

Closed
bengfarrell opened this issue Jan 12, 2023 · 1 comment
Closed

Slider Down state #1583

bengfarrell opened this issue Jan 12, 2023 · 1 comment
Labels
bug Results from a bug in the CSS implementation

Comments

@bengfarrell
Copy link

Description

I just happened to see a bug filed with the slider on Spectrum Web Components
adobe/spectrum-web-components#2836

I referred back to Spectrum CSS, and indeed the down state of the slider thumb doesn't activate on
https://opensource.adobe.com/spectrum-css/slider.html

Unfortunately, the down state is not on the spec on the web page (nor are any interactive states mentioned really)

However this state is clearly defined in the XD UI Kit specs

Steps to reproduce

Visit
https://opensource.adobe.com/spectrum-css/slider.html

Notice that the slider thumb, when interacting does not fill with a black/down color

Expected behavior

It should visually look like my screenshot posted from the XD UI Kit

Screenshots

UI Kit screen shot:
Screen Shot 2023-01-12 at 9 44 25 AM

@bengfarrell bengfarrell added the bug Results from a bug in the CSS implementation label Jan 12, 2023
@bernhard-adobe
Copy link
Contributor

Thank you @bengfarrell for pointing this out.
The active state is indeed missing from the current Slider in Spectrum CSS and the Spectrum XD file is correct.

I have added in the PR #1547.
2023-01-20_10-23-40 (1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Results from a bug in the CSS implementation
Projects
None yet
Development

No branches or pull requests

2 participants