Skip to content
This repository has been archived by the owner on Sep 15, 2022. It is now read-only.

Use author name from author page as display value #535

Closed
kptdobe opened this issue Dec 3, 2020 · 10 comments · Fixed by #645
Closed

Use author name from author page as display value #535

kptdobe opened this issue Dec 3, 2020 · 10 comments · Fixed by #645
Assignees
Labels
enhancement New feature or request

Comments

@kptdobe
Copy link
Contributor

kptdobe commented Dec 3, 2020

https://staging--theblog--adobe.hlx.page/ko/publish/2020/09/24/make-print-mockup.html#gs.n1n5rl

Name that appears for the author is Adobe Korea while the display name of the author on the author page is 어도비코리아. Adobe Korea is just the lookup value.

If an author page exists, we should use the first h2 as the display value - if no h2 or no author page, we use the text from the word document.

@kptdobe kptdobe added the enhancement New feature or request label Dec 3, 2020
@kptdobe kptdobe self-assigned this Dec 3, 2020
@kptdobe
Copy link
Contributor Author

kptdobe commented Dec 3, 2020

This has an impact on all the site: Anil Chakravarthy will now appear as Anil Chakravarthy, EVP & GM, Digital Experience Business and Worldwide Field Operations

@rofe
Copy link
Contributor

rofe commented Dec 3, 2020

Screenshot 2020-12-03 at 19 38 50

Would still work...

@rofe
Copy link
Contributor

rofe commented Dec 3, 2020

But maybe the business title, especially longer ones, should be moved to a h3?

@rofe rofe added the good first issue Good for newcomers label Dec 15, 2020
@kptdobe
Copy link
Contributor Author

kptdobe commented Dec 15, 2020

Note that while it is technically easy to implement, we need approval from authors.

@elaineskpt
Copy link
Collaborator

Cloned to Jira: https://jira.corp.adobe.com/browse/MWPW-80421

@kptdobe
Copy link
Contributor Author

kptdobe commented Feb 5, 2021

The initial idea does not fully work: if author on the article is Adobe Korea (author stored in index) but title on author page is 어도비코리아 then no articles for author 어도비코리아 will be found.

New proposal: allow the author in the Word document to be a link pointing to an author page - by <a href="/ko/authors/adobe-korea.html'>어도비코리아</a> would allow the Korean name to be displayed and indexed while the url to the author page is still latin characters based.

Todo:

  • adjust client side code to support "author as a link"
  • validate that indexing of the author would still work as before

@kptdobe
Copy link
Contributor Author

kptdobe commented Feb 5, 2021

@dominique-pfister What do you think ? will the indexer be ok with the change ?

@dominique-pfister
Copy link
Contributor

As long as the value to be indexed is addressable by a CSS selector, yes. If we change this just for Korean sites, we need to ensure that overriding the property for an index based on a default index will still work (and not e.g. create 2 properties with the same name).

@rofe
Copy link
Contributor

rofe commented Feb 6, 2021

If the matching is done on textContent, indexing should still work.

@kptdobe kptdobe removed their assignment Feb 25, 2021
@kptdobe kptdobe removed the good first issue Good for newcomers label Feb 25, 2021
@kptdobe
Copy link
Contributor Author

kptdobe commented Feb 25, 2021

I think this must be prioritised, with regions now we have many author urls which do not work (especially the JP ones).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants