Skip to content
This repository has been archived by the owner on Sep 15, 2022. It is now read-only.

[Posts] plain text products and topics not always removed #61

Closed
rofe opened this issue Jan 13, 2020 · 3 comments · Fixed by #62, #63 or #65
Closed

[Posts] plain text products and topics not always removed #61

rofe opened this issue Jan 13, 2020 · 3 comments · Fixed by #62, #63 or #65
Assignees
@rofe
Labels
bug Something isn't working pitch

Comments

@rofe
Copy link
Contributor

rofe commented Jan 13, 2020

For example, if the product paragraph looks like this:

<p>Products:</p>

then that paragraph won't be removed from the DOM.

It should be removed regardless of matched products.
@rofe rofe added bug Something isn't working pitch labels Jan 13, 2020
@rofe rofe self-assigned this Jan 13, 2020
@rofe
Copy link
Contributor Author

rofe commented Jan 13, 2020

Same for (empty) topics

@rofe rofe changed the title [Posts] plain text products not always removed [Posts] plain text products and topics not always removed Jan 13, 2020
@rofe rofe mentioned this issue Jan 13, 2020
Merged
@rofe rofe closed this as completed in #62 Jan 13, 2020
@rofe
Copy link
Contributor Author

rofe commented Jan 13, 2020

Not fixed

@rofe rofe reopened this Jan 13, 2020
@rofe rofe mentioned this issue Jan 13, 2020
Merged
@rofe rofe closed this as completed in #63 Jan 13, 2020
@rofe
Copy link
Contributor Author

rofe commented Jan 14, 2020

Still not fixed. Also, wrapper divs should only be added in case there is anything to wrap.

@rofe rofe reopened this Jan 14, 2020
@rofe rofe mentioned this issue Jan 14, 2020
Merged
@rofe rofe closed this as completed in #65 Jan 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rofe rofe

Labels
bug Something isn't working pitch
Projects
None yet
Milestone
No milestone
1 participant
@rofe