-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release] Stage to Main #241
Conversation
…quest. There is a default, so we do not want to send anything if we do not find the metadata
MWPW-154060: Preload most used scripts in head.html
MWPW-154363: Add param anaylitics sandbox
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
const miloDecorate = document.createElement('link'); | ||
|
||
miloStyles.setAttribute('as', 'style'); | ||
miloStyles.setAttribute('href', `${libs}/styles/styles.css`); |
Check warning
Code scanning / CodeQL
Client-side URL redirect Medium
user-provided value
tag.setAttribute('as', 'script'); | ||
}) | ||
|
||
miloUtils.setAttribute('href', `${libs}/utils/utils.js`); |
Check warning
Code scanning / CodeQL
Client-side URL redirect Medium
user-provided value
}) | ||
|
||
miloUtils.setAttribute('href', `${libs}/utils/utils.js`); | ||
miloDecorate.setAttribute('href', `${libs}/utils/decorate.js`); |
Check warning
Code scanning / CodeQL
Client-side URL redirect Medium
user-provided value
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #241 +/- ##
==========================================
+ Coverage 95.95% 95.98% +0.02%
==========================================
Files 11 11
Lines 1088 1095 +7
==========================================
+ Hits 1044 1051 +7
Misses 44 44 ☔ View full report in Codecov by Sentry. |
@JasonHowellSlavin Looks like you didn't squash and there are a lot of draft/test commits. Could you revert and do again? Edit: We decided this isn't a good idea and are going to leave as is. |
Test URLs: