[MWPW-130580-1] Browse by category: Added a full width variant #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
|
redvelvet511
changed the title
|
JingleH
added a commit
that referenced
this pull request
May 23, 2023
* feat(search-marquee): basic search bar layout done * feat(search-marquee): dropdown wip * Release with branchUrl fix and Template-x topics hotfix (#20) * fix(template-x): fix template-x blank template cta support (#18) * Pull Request Template Update (#14) Updating PR template test urls host to point at the adobecom repo * feat(template-x): topics-fixed (#19) Co-authored-by: Jingle Huang <jinglhua@adobe.com> --------- Co-authored-by: Qiyun Dai <pianoquin@gmail.com> Co-authored-by: Jingle Huang <jinglhua@adobe.com> * feat(search-marquee): basic search bar layout done * feat(search-marquee): dropdown wip * feat(search-marquee): wip * wip * feat(search-marquee): interaction wip * Merging stage to main sync up (#23) * fix(template-x): fix template-x blank template cta support (#18) * Pull Request Template Update (#14) Updating PR template test urls host to point at the adobecom repo * feat(template-x): topics-fixed (#19) Co-authored-by: Jingle Huang <jinglhua@adobe.com> * bring over autocomplete * separate autocomplete-api-v3 * feat(fullscreen-marquee-desktop): frames previewing and design fixes (#22) --------- Co-authored-by: Qiyun Dai <pianoquin@gmail.com> Co-authored-by: Jingle Huang <32369333+JingleH@users.noreply.github.com> Co-authored-by: Jingle Huang <jinglhua@adobe.com> Co-authored-by: William Ste-Marie <williambsm@hotmail.fr> * Update search-marquee.js * feat(search-marquee): trends done * dropdown interaction done * initial search redirection integration * remove search auto complete error * search redirect with q param wip * Update search-marquee.js * templates.js revamp to use metadata wip * remove unused code * Update template-search-api-v3.js * Further reduce sheet load * templates.js refactor wip * adding options to hide linklists * search marquee done * EOF line break * delete unused files * reverting api key * update api key * 404ing for page without proper metadata * localized autocomplete * localized version functioning as intended * linting * linting * Add tracking code and remove unused function * update free-plan-width styling * update search api * fix typo * fixing redirect rule * [MWPW-130580-1] Browse by category: Added a full width variant (#30) Added fullwidth variant for both card and default version * undo encoding * multi-word tasks connected by dash * title to dc:title --------- Co-authored-by: Jingle Huang <32369333+JingleH@users.noreply.github.com> Co-authored-by: Jingle Huang <jinglhua@adobe.com> Co-authored-by: Apoorva Ganapathy <37915358+apganapa@users.noreply.github.com> Co-authored-by: William Ste-Marie <williambsm@hotmail.fr> Co-authored-by: redvelvet511 <113856982+redvelvet511@users.noreply.github.com>
JingleH
added a commit
that referenced
this pull request
May 30, 2023
* fix(template-x): fix template-x blank template cta support * fix(template-x): dynamic icons fix * fix(template-x): cleanup * fix(template-x): cleanup * fix(template-x): tabindex fix for hover preview * jump-to-category hover tweak * feat(browse-by-category-column): first commit * fix(browse-by-category): fix old block along with new * fix(browse-by-category): fix text align on card block * refactor * fix(browse-by-category): pr review changes * fix(browse-by-category): minor pr change fix * fix(browse-by-category): remove extra media query * fix(browse-by-category): fix media query * fix(browse-by-category): add extra line at the end * fix(browse-by-category): target block instead of container L196 * fix(branch-link): add referrer param (#29) * [MWPW-130580] Search Marquee (#28) * feat(search-marquee): basic search bar layout done * feat(search-marquee): dropdown wip * Release with branchUrl fix and Template-x topics hotfix (#20) * fix(template-x): fix template-x blank template cta support (#18) * Pull Request Template Update (#14) Updating PR template test urls host to point at the adobecom repo * feat(template-x): topics-fixed (#19) Co-authored-by: Jingle Huang <jinglhua@adobe.com> --------- Co-authored-by: Qiyun Dai <pianoquin@gmail.com> Co-authored-by: Jingle Huang <jinglhua@adobe.com> * feat(search-marquee): basic search bar layout done * feat(search-marquee): dropdown wip * feat(search-marquee): wip * wip * feat(search-marquee): interaction wip * Merging stage to main sync up (#23) * fix(template-x): fix template-x blank template cta support (#18) * Pull Request Template Update (#14) Updating PR template test urls host to point at the adobecom repo * feat(template-x): topics-fixed (#19) Co-authored-by: Jingle Huang <jinglhua@adobe.com> * bring over autocomplete * separate autocomplete-api-v3 * feat(fullscreen-marquee-desktop): frames previewing and design fixes (#22) --------- Co-authored-by: Qiyun Dai <pianoquin@gmail.com> Co-authored-by: Jingle Huang <32369333+JingleH@users.noreply.github.com> Co-authored-by: Jingle Huang <jinglhua@adobe.com> Co-authored-by: William Ste-Marie <williambsm@hotmail.fr> * Update search-marquee.js * feat(search-marquee): trends done * dropdown interaction done * initial search redirection integration * remove search auto complete error * search redirect with q param wip * Update search-marquee.js * templates.js revamp to use metadata wip * remove unused code * Update template-search-api-v3.js * Further reduce sheet load * templates.js refactor wip * adding options to hide linklists * search marquee done * EOF line break * delete unused files * reverting api key * update api key * 404ing for page without proper metadata * localized autocomplete * localized version functioning as intended * linting * linting * Add tracking code and remove unused function * update free-plan-width styling * update search api * fix typo * fixing redirect rule * [MWPW-130580-1] Browse by category: Added a full width variant (#30) Added fullwidth variant for both card and default version * undo encoding * multi-word tasks connected by dash * title to dc:title --------- Co-authored-by: Jingle Huang <32369333+JingleH@users.noreply.github.com> Co-authored-by: Jingle Huang <jinglhua@adobe.com> Co-authored-by: Apoorva Ganapathy <37915358+apganapa@users.noreply.github.com> Co-authored-by: William Ste-Marie <williambsm@hotmail.fr> Co-authored-by: redvelvet511 <113856982+redvelvet511@users.noreply.github.com> * added fallback msg to empty results (#32) Co-authored-by: Jingle Huang <jinglhua@adobe.com> * Updated to work with new localized templates sheet (#36) * added AND relationship (#43) Co-authored-by: Jingle Huang <jinglhua@adobe.com> --------- Co-authored-by: Apoorva Ganapathy <37915358+apganapa@users.noreply.github.com> Co-authored-by: Qiyun Dai <pianoquin@gmail.com> Co-authored-by: redvelvet511 <113856982+redvelvet511@users.noreply.github.com> Co-authored-by: Jingle Huang <jinglhua@adobe.com> Co-authored-by: William Ste-Marie <williambsm@hotmail.fr> Co-authored-by: Casey Tokarchuk <105597527+toka1300@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix [MWPW-130580-1]
Description:
• Added a variant (fullwidth) to browse by category.
• Added JS script to add class to parentNode wrapper
• Added CSS to target new variant
Test URLS:
• Before: https://main--express--adobecom.hlx.page/express/templates/?lighthouse=on
• After: https://mwpw-130580--express--adobecom.hlx.page/express/templates/?lighthouse=on