Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-131973]: Template X - add dynamic collection ID #49

Merged
merged 2 commits into from
Jun 6, 2023
Merged

Conversation

qiyundai
Copy link
Collaborator

@qiyundai qiyundai commented Jun 6, 2023

Please always provide the JIRA issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix MWPW-131973

Description:
Added expectation for collectionID from props and set a default collection ID in contructProps();

Test URLs:

@aem-code-sync
Copy link

aem-code-sync bot commented Jun 6, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Jun 6, 2023

Page Scores Audits Google
/express/templates/?lighthouse=on PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@JingleH JingleH merged commit 8975a98 into stage Jun 6, 2023
@aem-code-sync
Copy link

aem-code-sync bot commented Jun 6, 2023

Page Scores Audits Google
/express/templates/?lighthouse=on PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@qiyundai qiyundai deleted the mwpw-131973 branch September 20, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants