Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-133250] CTA Carousel with versatility #78

Merged
merged 4 commits into from
Jul 19, 2023
Merged

Conversation

qiyundai
Copy link
Collaborator

@qiyundai qiyundai commented Jul 6, 2023

Please always provide the JIRA issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix MWPW-133250

Description:
A new CTA card carousel for any use case that require a carousel that contains CTAs, image/video link, svg icon overlay, CTA text separate from CTA buttons, hover effect with extra subtext.

Test URLs:

@aem-code-sync
Copy link

aem-code-sync bot commented Jul 6, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Jul 6, 2023

Page Scores Audits Google
/drafts/qiyundai/homepage-v3/cta-carousel?lighthouse=on PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Jul 11, 2023

Page Scores Audits Google
/drafts/qiyundai/homepage-v3/cta-carousel?lighthouse=on PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

express/blocks/cta-carousel/cta-carousel.css Outdated Show resolved Hide resolved
express/blocks/cta-carousel/cta-carousel.js Outdated Show resolved Hide resolved
@aem-code-sync
Copy link

aem-code-sync bot commented Jul 19, 2023

Page Scores Audits Google
/drafts/qiyundai/homepage-v3/cta-carousel?lighthouse=on PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2023

Codecov Report

Merging #78 (a343d1c) into stage (c3b244e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            stage      #78   +/-   ##
=======================================
  Coverage   39.25%   39.25%           
=======================================
  Files           9        9           
  Lines        4991     4991           
=======================================
  Hits         1959     1959           
  Misses       3032     3032           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aem-code-sync
Copy link

aem-code-sync bot commented Jul 19, 2023

Page Scores Audits Google
/drafts/qiyundai/homepage-v3/cta-carousel?lighthouse=on PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@JingleH JingleH merged commit bbdc437 into stage Jul 19, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants