Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] Stage to Main #2157

Merged
merged 4 commits into from
Apr 18, 2024
Merged

[Release] Stage to Main #2157

merged 4 commits into from
Apr 18, 2024

Conversation

Blainegunn
Copy link
Contributor

@Blainegunn Blainegunn commented Apr 17, 2024 •
edited
Loading

@Blainegunn Blainegunn requested a review from a team as a code owner April 17, 2024 17:36
@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Apr 17, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@Blainegunn Blainegunn changed the title [Release [Release] Stage to Main Apr 17, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.65%. Comparing base (cb1c9a9) to head (1cf982e).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2157      +/-   ##
==========================================
+ Coverage   96.62%   96.65%   +0.03%     
==========================================
  Files         165      165              
  Lines       43484    43484              
==========================================
+ Hits        42016    42030      +14     
+ Misses       1468     1454      -14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Blainegunn Blainegunn requested review from a team April 17, 2024 18:00
@Blainegunn Blainegunn added run-nala Run Nala Test Automation against PR needs-verification PR requires E2E testing by a reviewer Ready for Main This PR is ready almost ready to be merged into main. Please inform all T1 QAs labels Apr 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@robert-bogos robert-bogos merged commit 15582b8 into main Apr 18, 2024
24 of 25 checks passed
@github-actions github-actions bot mentioned this pull request Apr 30, 2024
Closed
@mokimo mokimo mentioned this pull request May 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigadamvenkata sigadamvenkata sigadamvenkata approved these changes

@Roycethan Roycethan Roycethan approved these changes

@JackySun9 JackySun9 JackySun9 approved these changes

@mokimo mokimo mokimo approved these changes

@Dli3 Dli3 Dli3 approved these changes

@tedAir tedAir tedAir approved these changes

Assignees
No one assigned
Labels
BAcom SOT 👌 CC SOT 👌 DC SOT 👌 MIQ SOT👌 needs-verification PR requires E2E testing by a reviewer Ready for Main This PR is ready almost ready to be merged into main. Please inform all T1 QAs run-nala Run Nala Test Automation against PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@Blainegunn @tedAir @Dli3 @mokimo @JackySun9 @Roycethan @sigadamvenkata @robert-bogos @vhargrave @vgoodric