MWPW-146491 Fast follow to change timeout analytic and use Date instead of performance #2163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
vgoodric
added
verified
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2163 +/- ##
==========================================
+ Coverage 96.36% 96.63% +0.26%
==========================================
Files 166 165 -1
Lines 42531 43484 +953
==========================================
+ Hits 40986 42021 +1035
+ Misses 1545 1463 -82 ☔ View full report in Codecov by Sentry. |
vgoodric
force-pushed
the
meptimeoutagain
branch
from
6f48eb3
to
eb1fa53
Compare
chrischrischris
approved these changes
Apr 18, 2024
rgclayton
approved these changes
Apr 18, 2024
joaquinrivero
added a commit
to joaquinrivero/milo
that referenced
this pull request
Apr 19, 2024
* main: MWPW-146491 Fast follow to change timeout analytic and use Date instead of performance (adobecom#2163) MWPW-146582: a11y aria attributes (adobecom#2156)
mokimo
pushed a commit
to mokimo/milo
that referenced
this pull request
Apr 30, 2024
…ad of performance (adobecom#2163) * Do not use Error when timing out * revert and lint fix --------- Co-authored-by: ChrisChrisChris <chrischrischris@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a PR recently #2140 that increased the timeout and improved error handling. We're seeing some unexpected results and want to dig in a little further. So we're updating the analytics again.
Fast follow for: MWPW-146491
Test URLs:
Before: https://main--milo--adobecom.hlx.page/?martech=off
After: https://meptimeoutagain--milo--adobecom.hlx.page/?martech=off
Page with Target on:
https://main--homepage--adobecom.hlx.page/homepage/index-loggedout
https://main--homepage--adobecom.hlx.page/homepage/index-loggedout?milolibs=meptimeoutagain
Note: this is listed as high priority because in Dexter, if a Target response came in quite late, the page would "flicker" but they would still get the updates. In Milo, MEP can only alter the page before decoration. And we do not want to wait indefinitely before showing the user the page. So we opted to pick a timeout and move on without the updates if needed. This resulted in some users being categorized as seeing updates, but viewing an unaltered page.
Some discrepancy is fine, but currently, the discrepancy is so high, that we cannot rely on MEP test results, thus rendering testing in Milo useless. Since testing yields over 100M/year, we are anxious to resolve the issue as quickly as possible.
This code exclusively impacts pages that have Target/MEP enabled. Homepage is the largest traffic consumer of this. To be extra safe, I had 2 people who are very familiar with homepage and it's personalization review the page for an SOTs equivalent review and they signed off.