[Release] Stage to Main #2186
Merged
[Release] Stage to Main #2186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vladen
commented
Apr 23, 2024
vladen
commented
- MWPW-135821 introduce mep custom action & use it for card collection #2152
- MWPW-146129 [Original: #2123] App Launcher overlaps the menu in Unav in the devices #2184
…in the devices (#2184) * Closes the global nav expanded wrapper in non desktop viewports when the user interacts with the universal nav (Notifications, app switcher, and profile/sign in button) * We no longer use element.click * made toggleMenuMobile a method of the Gnav class * Extracted the toggle expanded check into its own function * a little cleanup
…2152) * MWPW-135821 introduce custom action - and inaugurating first custom action for replacing cards in collection * MWPW-135821 use prefix in selector * MWPW-135821 adding preview data --------- Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com>
vladen
added
run-nala
vladen
requested review from
a team,
overmyheadandbody,
mokimo and
narcis-radu
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2186 +/- ##
=======================================
Coverage 96.65% 96.66%
=======================================
Files 165 165
Lines 43485 43525 +40
=======================================
+ Hits 42032 42073 +41
+ Misses 1453 1452 -1 ☔ View full report in Codecov by Sentry. |
Roycethan
approved these changes
Apr 23, 2024
JackySun9
approved these changes
Apr 23, 2024
Dli3
approved these changes
Apr 23, 2024
tedAir
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.