MWPW-146001 parallelize literals call #2187

npeltier · 2024-04-23T15:25:23Z

Before

After

Test URLs:

Page	LHS Before	LHS After	FCP	TBT
https://main–cc–adobecom.hlx.live/products/substance3d/apps/designer ?martech=off	86	89	-0,6	-50
https://main--cc--adobecom.hlx.live/products/substance3d/apps/modeler?martech=off	87	90	-0,7	0
https://main--cc--adobecom.hlx.live/products/substance3d/apps/painter?martech=off	87	93	-0,5	-10
https://main--cc--adobecom.hlx.live/products/substance3d/apps/sampler?martech=off	88	94	-0,6	30
https://main--cc--adobecom.hlx.live/products/substance3d/apps/stager?martech=off	89	94	-0,6	0
https://main--cc--adobecom.hlx.live/products/substance3d/3d-assets?martech=off	84	86	-0,2	-90

https://git.corp.adobe.com/wcms/tacocat.js/pull/570
https://git.corp.adobe.com/wcms/tacocat.js/pull/573

aem-code-sync · 2024-04-23T15:25:43Z

Page	Scores	Audits	Google
/?martech=off

yesil · 2024-04-23T17:05:45Z

libs/blocks/merch/merch.js

@@ -3,7 +3,13 @@ import {
 } from '../../utils/utils.js';
 import { replaceKey } from '../../features/placeholders.js';

-export const PRICE_LITERALS_URL = 'https://milo.adobe.com/libs/commerce/price-literals.json';
+if (!window.commerce) window.commerce = {};


I would like to avoid introducing a namespace like window.commerce.
here the promise can be set on the fonction similar to fetchEntitlements.promise effectively becomes a module scoped data.

github-actions · 2024-04-24T01:11:13Z

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

yesil · 2024-04-24T08:16:42Z

@npeltier, for the record, can you add the tacocat PR in the ticket description.
your changes look good, once the unit tests are fixed, it is 👍

afmicka · 2024-04-24T14:17:25Z

@npeltier these changes are failing all Nala tests. Lets please connect and check the cause

narcis-radu · 2024-04-24T14:39:50Z

@npeltier - I'm seeing the extra DNS calls because the price literals are served from milo.adobe.com. I think there was a similar limitation with the Global Navigation placeholders and we managed to fix it. Would you be interested in updating the code and improve performance? cc @mokimo , @overmyheadandbody , @robert-bogos , @yesil

mokimo · 2024-04-24T14:48:39Z

We moved our placeholders from the milo sharepoint, to the federal one.
Instead of https://milo.adobe.com/globalnav/placeholders.json we resolve them from
https://www.adobe.com/federal/globalnav/placeholders.json (+ consuming projects, e.g. business.adobe.com/federal/globalnav/placeholders.json)

We shouldn't make any prod requests to milo.adobe.com - instead we should use the federal project as @narcis-radu mentioned

npeltier · 2024-04-24T15:19:56Z

@mokimo @narcis-radu is there an onboarding documentation :) ? (cc @yesil )
or i just copy the document in that project?

npeltier · 2024-04-24T15:26:39Z

i think that is it, will do a copy & update code here :)

narcis-radu · 2024-04-24T15:48:46Z

@npeltier - thanks! If you're updating the path as part of this PR, please make sure to update the JIRA ticket as well. Otherwise, I can create a new ticket for you if you want to treat it as a separate enhancement.

mokimo · 2024-04-24T16:01:46Z

@npeltier I created a ticket to write some docs.

TL:DR; creating something under federal/federal will just work OOTB and then be available on those origins (reference)

// TODO when porting this to milo core, we should define this on config level
// and allow consumers to add their own origins after setting up the CDN
const allowedOrigins = [
  'https://www.adobe.com',
  'https://business.adobe.com',
  'https://blog.adobe.com',
  'https://milo.adobe.com',
];

You could use any of the origins, and/or www.adobe.com as fallback - just make sure to publish the sheet so it's available on .live

mokimo

Cool, awesome to see a new home for the price literals

npeltier · 2024-04-24T17:28:09Z

@npeltier - thanks! If you're updating the path as part of this PR, please make sure to update the JIRA ticket as well. Otherwise, I can create a new ticket for you if you want to treat it as a separate enhancement.

i added it here. We still have a more "active" file i copied there too for now, i created https://jira.corp.adobe.com/browse/MWPW-147239 for that matter.

Thanks to both of you guys! i'm just a few UT fixes away now :-]

libs/blocks/merch/merch.js

* Update code owners for feds (#2194) Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> * Harden preflight link checking (#2169) * Filter out empty `hrefs` before sending to spidy. * Harden link check to be more robust against Spidy API. * Update link check language. * Better onboarding support. * Adds fallbacks if `.milo/config` has not been added. * Fix for missing Word doc reference, under general tab. Resolves: [MWPW-146695](https://jira.corp.adobe.com/browse/MWPW-146695) Co-authored-by: Ryan Clayton <rclayton@adobe.com> * MWPW-146755: RTL merch icon padding (#2162) * RTL padding merch icon * dep update * MWPW-146001 parallelize literals call (#2187) * MWPW-146001 parallelize literals call * MWPW-146001 move promise to the function * MWPW-146001 fix commerce library * MWPW-146001 update literals endpoint * MWPW-146001 fixing commerce ut --------- Co-authored-by: Narcis Radu <github@narcisradu.ro> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Ryan Clayton <rgclayton@gmail.com> Co-authored-by: Ryan Clayton <rclayton@adobe.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com>

* actions scroller center & section grid center * update scroller test to cover all code branches * update test mock to avoid nav test * put back sticky and center styles * [Release] Stage to Main (#2208) * Update code owners for feds (#2194) Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> * Harden preflight link checking (#2169) * Filter out empty `hrefs` before sending to spidy. * Harden link check to be more robust against Spidy API. * Update link check language. * Better onboarding support. * Adds fallbacks if `.milo/config` has not been added. * Fix for missing Word doc reference, under general tab. Resolves: [MWPW-146695](https://jira.corp.adobe.com/browse/MWPW-146695) Co-authored-by: Ryan Clayton <rclayton@adobe.com> * MWPW-146755: RTL merch icon padding (#2162) * RTL padding merch icon * dep update * MWPW-146001 parallelize literals call (#2187) * MWPW-146001 parallelize literals call * MWPW-146001 move promise to the function * MWPW-146001 fix commerce library * MWPW-146001 update literals endpoint * MWPW-146001 fixing commerce ut --------- Co-authored-by: Narcis Radu <github@narcisradu.ro> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Ryan Clayton <rgclayton@gmail.com> Co-authored-by: Ryan Clayton <rclayton@adobe.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com> --------- Co-authored-by: Ruchika Sinha <69535463+Ruchika4@users.noreply.github.com> Co-authored-by: Narcis Radu <github@narcisradu.ro> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Ryan Clayton <rgclayton@gmail.com> Co-authored-by: Ryan Clayton <rclayton@adobe.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com>

* actions scroller center & section grid center * update scroller test to cover all code branches * update test mock to avoid nav test * put back sticky and center styles * [Release] Stage to Main (adobecom#2208) * Update code owners for feds (adobecom#2194) Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> * Harden preflight link checking (adobecom#2169) * Filter out empty `hrefs` before sending to spidy. * Harden link check to be more robust against Spidy API. * Update link check language. * Better onboarding support. * Adds fallbacks if `.milo/config` has not been added. * Fix for missing Word doc reference, under general tab. Resolves: [MWPW-146695](https://jira.corp.adobe.com/browse/MWPW-146695) Co-authored-by: Ryan Clayton <rclayton@adobe.com> * MWPW-146755: RTL merch icon padding (adobecom#2162) * RTL padding merch icon * dep update * MWPW-146001 parallelize literals call (adobecom#2187) * MWPW-146001 parallelize literals call * MWPW-146001 move promise to the function * MWPW-146001 fix commerce library * MWPW-146001 update literals endpoint * MWPW-146001 fixing commerce ut --------- Co-authored-by: Narcis Radu <github@narcisradu.ro> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Ryan Clayton <rgclayton@gmail.com> Co-authored-by: Ryan Clayton <rclayton@adobe.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com> --------- Co-authored-by: Ruchika Sinha <69535463+Ruchika4@users.noreply.github.com> Co-authored-by: Narcis Radu <github@narcisradu.ro> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Ryan Clayton <rgclayton@gmail.com> Co-authored-by: Ryan Clayton <rclayton@adobe.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com>

* MWPW-146001 parallelize literals call * MWPW-146001 move promise to the function * MWPW-146001 fix commerce library * MWPW-146001 update literals endpoint * MWPW-146001 fixing commerce ut

* actions scroller center & section grid center * update scroller test to cover all code branches * update test mock to avoid nav test * put back sticky and center styles * [Release] Stage to Main (adobecom#2208) * Update code owners for feds (adobecom#2194) Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> * Harden preflight link checking (adobecom#2169) * Filter out empty `hrefs` before sending to spidy. * Harden link check to be more robust against Spidy API. * Update link check language. * Better onboarding support. * Adds fallbacks if `.milo/config` has not been added. * Fix for missing Word doc reference, under general tab. Resolves: [MWPW-146695](https://jira.corp.adobe.com/browse/MWPW-146695) Co-authored-by: Ryan Clayton <rclayton@adobe.com> * MWPW-146755: RTL merch icon padding (adobecom#2162) * RTL padding merch icon * dep update * MWPW-146001 parallelize literals call (adobecom#2187) * MWPW-146001 parallelize literals call * MWPW-146001 move promise to the function * MWPW-146001 fix commerce library * MWPW-146001 update literals endpoint * MWPW-146001 fixing commerce ut --------- Co-authored-by: Narcis Radu <github@narcisradu.ro> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Ryan Clayton <rgclayton@gmail.com> Co-authored-by: Ryan Clayton <rclayton@adobe.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com> --------- Co-authored-by: Ruchika Sinha <69535463+Ruchika4@users.noreply.github.com> Co-authored-by: Narcis Radu <github@narcisradu.ro> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Robert Bogos <146744221+robert-bogos@users.noreply.github.com> Co-authored-by: Ryan Clayton <rgclayton@gmail.com> Co-authored-by: Ryan Clayton <rclayton@adobe.com> Co-authored-by: Axel Cureno Basurto <axelcureno@gmail.com> Co-authored-by: Nicolas Peltier <1032754+npeltier@users.noreply.github.com>

MWPW-146001 parallelize literals call

9eb7833

npeltier added run-nala Run Nala Test Automation against PR commerce needs-verification PR requires E2E testing by a reviewer labels Apr 23, 2024

npeltier requested a review from a team as a code owner April 23, 2024 15:25

Merge branch 'stage' of github.com:adobecom/milo into MWPW-146001

ebf374b

yesil reviewed Apr 23, 2024

View reviewed changes

Axelcureno approved these changes Apr 24, 2024

View reviewed changes

npeltier and others added 2 commits April 24, 2024 08:08

MWPW-146001 move promise to the function

f04fb4d

Merge branch 'stage' into MWPW-146001

fa7b51b

mokimo approved these changes Apr 24, 2024

View reviewed changes

npeltier added 2 commits April 24, 2024 12:18

MWPW-146001 fix commerce library

46a2b46

Merge branch 'MWPW-146001' of github.com:npeltier/milo into MWPW-146001

c6d0f1a

yesil approved these changes Apr 24, 2024

View reviewed changes

MWPW-146001 update literals endpoint

28b98a4

mokimo approved these changes Apr 24, 2024

View reviewed changes

skumar09 added run-nala Run Nala Test Automation against PR and removed run-nala Run Nala Test Automation against PR labels Apr 24, 2024

mokimo reviewed Apr 25, 2024

View reviewed changes

libs/blocks/merch/merch.js Show resolved Hide resolved

MWPW-146001 fixing commerce ut

9cc537d

afmicka added verified PR has been E2E tested by a reviewer and removed needs-verification PR requires E2E testing by a reviewer labels Apr 25, 2024

npeltier added the Ready for Stage label Apr 26, 2024

npeltier mentioned this pull request Apr 26, 2024

MWPW-147239 use federal for checkout-links too #2212

Closed

vladen merged commit dac9c7e into adobecom:stage Apr 26, 2024
14 of 15 checks passed

vladen mentioned this pull request Apr 26, 2024

[Release] Stage to Main #2208

Merged

github-actions bot mentioned this pull request Apr 30, 2024

[Release] Stage to Main mokimo/milo#57

Closed

mokimo mentioned this pull request May 7, 2024

[Release] Stage to Main mokimo/milo#59

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MWPW-146001 parallelize literals call #2187

MWPW-146001 parallelize literals call #2187

npeltier commented Apr 23, 2024 •

edited

Loading

aem-code-sync bot commented Apr 23, 2024 •

edited

Loading

yesil Apr 23, 2024

github-actions bot commented Apr 24, 2024

yesil commented Apr 24, 2024

afmicka commented Apr 24, 2024

narcis-radu commented Apr 24, 2024

mokimo commented Apr 24, 2024 •

edited

Loading

npeltier commented Apr 24, 2024 •

edited

Loading

npeltier commented Apr 24, 2024

narcis-radu commented Apr 24, 2024

mokimo commented Apr 24, 2024

mokimo left a comment

npeltier commented Apr 24, 2024

MWPW-146001 parallelize literals call #2187

MWPW-146001 parallelize literals call #2187

Conversation

npeltier commented Apr 23, 2024 • edited Loading

aem-code-sync bot commented Apr 23, 2024 • edited Loading

yesil Apr 23, 2024

Choose a reason for hiding this comment

github-actions bot commented Apr 24, 2024

yesil commented Apr 24, 2024

afmicka commented Apr 24, 2024

narcis-radu commented Apr 24, 2024

mokimo commented Apr 24, 2024 • edited Loading

npeltier commented Apr 24, 2024 • edited Loading

npeltier commented Apr 24, 2024

narcis-radu commented Apr 24, 2024

mokimo commented Apr 24, 2024

mokimo left a comment

Choose a reason for hiding this comment

npeltier commented Apr 24, 2024

npeltier commented Apr 23, 2024 •

edited

Loading

aem-code-sync bot commented Apr 23, 2024 •

edited

Loading

mokimo commented Apr 24, 2024 •

edited

Loading

npeltier commented Apr 24, 2024 •

edited

Loading