Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] Stage to Main #2197

Merged
merged 2 commits into from
Apr 24, 2024
Merged

[Release] Stage to Main #2197

merged 2 commits into from
Apr 24, 2024

Conversation

Ruchika4
Copy link
Contributor

@Ruchika4 Ruchika4 commented Apr 24, 2024 •
edited
Loading

Note: This PR has a code update in a block that is not used in any live page.

@Ruchika4 Ruchika4 added run-nala Run Nala Test Automation against PR new-feature New block or other feature needs-verification PR requires E2E testing by a reviewer Ready for Main This PR is ready almost ready to be merged into main. Please inform all T1 QAs labels Apr 24, 2024
@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Apr 24, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@Ruchika4 Ruchika4 requested review from a team April 24, 2024 16:21
@Ruchika4
Copy link
Contributor Author

@spadmasa @sigadamvenkata Please test this once on stage.adobe.com url once. Thanks

@Ruchika4 Ruchika4 removed the new-feature New block or other feature label Apr 24, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.64%. Comparing base (b764ada) to head (55ad0f1).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2197      +/-   ##
==========================================
- Coverage   96.68%   96.64%   -0.04%     
==========================================
  Files         165      165              
  Lines       43525    43523       -2     
==========================================
- Hits        42080    42062      -18     
- Misses       1445     1461      +16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spadmasa
Copy link

Verified in stage on below test url :
https://www.stage.adobe.com/creativecloud/animation/branchtest.html
image
image

image

image

image

@Ruchika4 Ruchika4 added verified PR has been E2E tested by a reviewer and removed needs-verification PR requires E2E testing by a reviewer labels Apr 24, 2024
@Ruchika4 Ruchika4 merged commit 5291cb1 into main Apr 24, 2024
16 of 17 checks passed
@github-actions github-actions bot mentioned this pull request Apr 30, 2024
Closed
@mokimo mokimo mentioned this pull request May 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigadamvenkata sigadamvenkata sigadamvenkata approved these changes

@Roycethan Roycethan Roycethan approved these changes

@JackySun9 JackySun9 JackySun9 approved these changes

@mokimo mokimo mokimo approved these changes

@Dli3 Dli3 Dli3 approved these changes

@tedAir tedAir tedAir approved these changes

Assignees
No one assigned
Labels
BAcom SOT 👌 CC SOT 👌 DC SOT 👌 Homepage SOT 👌 MIQ SOT👌 Ready for Main This PR is ready almost ready to be merged into main. Please inform all T1 QAs run-nala Run Nala Test Automation against PR verified PR has been E2E tested by a reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Ruchika4 @spadmasa @tedAir @Dli3 @mokimo @JackySun9 @Roycethan @sigadamvenkata