-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various catalog fixes + SWC updates #2347
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2347 +/- ##
=======================================
Coverage 95.65% 95.66%
=======================================
Files 173 173
Lines 45165 45176 +11
=======================================
+ Hits 43204 43216 +12
+ Misses 1961 1960 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm assuming no regression :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also on kitchen sync there is a trouble with the card title |
@3ch023 the icon issue is not a product of this PR. the card collection index used in the Milo page is hand crafted and not entirely correct. Any style issue should be reported with examples in kitchen sink or other pages. |
@yesil Tickets attached to this PR are verified, they are fixed. I see a other issue and tracked here https://jira.corp.adobe.com/browse/MWPW-150558 plz let me know whether you are planning to fix it here or in another PR, thanks |
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
@3ch023 could you please review again? |
@Roycethan @afmicka as per the design: https://xd.adobe.com/view/84200b4e-caf9-428f-98cf-7198a236a4bc-d173/screen/9e57473d-b3de-4ad1-8627-ca485d21871c/variables/ the tablet should show 3 cards in the same row and buttons must be stretched. Let me know if you disagree. |
@yesil Thanks for fixing regressions in Mini compare chart card, few issues/regressions in Catalog page mentioning here:
cc @afmicka |
@yesil there is one remaining gap to be fixed. Tablet view with 2 columns. The gap is still smaller with your changes. Could you please also check the font size for the CTAs? It is smaller with your changes (15px) than on prod (17px) but not sure out of XD what value it should really be.
cc: @Roycethan |
This PR addresses several small UI fixes for the upcoming catalog page release.
Includes:
Required by: adobecom/cc#307
Resolves:
Test URLs:
CC Test URL: https://catalog-fixes--cc--adobecom.hlx.live/products/catalog?martech=off&milolibs=product-catalog-fixes
Performance
hlx.live score ~86pts: https://pagespeed.web.dev/analysis/https-product-catalog-fixes--milo--adobecom-hlx-live-drafts-ilyas-merch-card-collection/9h7jey7q1y?form_factor=mobile