Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-149470[MILO][MEP] Remove sendTargetResponseAnalytics function #2371

Closed
wants to merge 2 commits into from

Conversation

markpadbe
Copy link
Contributor

Remove function temporarily added to collect analytics data

to check the effect of the code change, filter the network tab for the word "collect". The current code sends an event with the timeout information. The new code does not.

Resolves: MWPW-149470

Test URLs:

@markpadbe markpadbe added verified PR has been E2E tested by a reviewer zero-impact high priority Why is this a high priority? Blocker? Critical? Dependency? labels May 24, 2024
@markpadbe markpadbe requested a review from a team as a code owner May 24, 2024 17:26
Copy link
Contributor

aem-code-sync bot commented May 24, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.64%. Comparing base (29d0a16) to head (19fb744).

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #2371      +/-   ##
==========================================
- Coverage   95.65%   95.64%   -0.01%     
==========================================
  Files         173      173              
  Lines       45165    45165              
==========================================
- Hits        43204    43200       -4     
- Misses       1961     1965       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

Copy link
Contributor

github-actions bot commented Jun 4, 2024

This PR has not been updated recently and will be closed in 7 days if no action is taken. Please ensure all checks are passing, https://github.com/orgs/adobecom/discussions/997 provides instructions. If the PR is ready to be merged, please mark it with the "Ready for Stage" label.

@github-actions github-actions bot added the Stale label Jun 4, 2024
@robert-bogos robert-bogos self-requested a review June 10, 2024 13:31
Copy link
Contributor

@robert-bogos robert-bogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markpadbe There are conflicts with Stage, can you please look into that?

@vgoodric vgoodric closed this Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority Why is this a high priority? Blocker? Critical? Dependency? Stale verified PR has been E2E tested by a reviewer zero-impact
Projects
None yet
5 participants