Media & Z-Pattern updates - content margins and 2-5up grid support #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added detail styles to text-transform:uppercase Removed redundant asside styles
Removed redundant asside styles.
|
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
|
Codecov Report
@@ Coverage Diff @@
## main #429 +/- ##
==========================================
- Coverage 98.90% 98.88% -0.03%
==========================================
Files 80 79 -1
Lines 21016 20986 -30
==========================================
- Hits 20786 20752 -34
- Misses 230 234 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
seanchoi-dev
approved these changes
Jan 31, 2023
rgclayton
approved these changes
Feb 1, 2023
|
sukamat
pushed a commit
to sukamat/milo
that referenced
this pull request
Feb 8, 2023
…dobecom#429) * updates to media to support section meta two-five ups * updated default margins * Added detail styles to text-transform:uppercase Removed redundant asside styles. * test coverate on image w/ out alt text --------- Co-authored-by: thi64146 <thi64146@adobe.com> Co-authored-by: Ryan Clayton <rgclayton@gmail.com>
sukamat
pushed a commit
to sukamat/milo
that referenced
this pull request
Feb 8, 2023
base project page placeholder fg css connect to SP and init floodgate project Reads the floodgate project and injects SP data Add asset support to library Add Franklin customer library support Remove 3rd party libraries if not used Add utils test coverage (adobecom#427) Co-authored-by: Ryan Clayton <rclayton@adobe.com> A simple `reading-time` block to estimate the reading time of the article (adobecom#356) * A simple block to estimate the reading time of the article * reading-time: typo in the css * reading-time: small change to the css * reading-time PR review changes * added placeholders for localization of the '5 min read' text * [reading-time]: add a placeholder key for singular reading time value * [reading-time]: less strict scoping for css * [reading-time]: less strict scoping for css * [reading-time]: text-align center only if it's in a center section * reading-time tests added * reading-time tests added Fixing bug for faas import from link clicked. (adobecom#424) * Fixing bug for faas import from link clicked. * adding ||= sytex. * same as before. MWPW-122611 - [GH Action] Old browser function detection (adobecom#423) * MWPW-122611 - [GH Action] Old browser function detection - add a Github action to check for unsupported functions * MWPW-122611 - [GH Action] Old browser function detection - add a Github action to check for unsupported functions * MWPW-122611 - [GH Action] Old browser function detection - add a Github action to check for unsupported functions * MWPW-122611 - [GH Action] Old browser function detection - add a Github action to check for unsupported functions * MWPW-122611 - [GH Action] Old browser function detection - add a Github action to check for unsupported functions * MWPW-122611 - [GH Action] Old browser function detection - add a Github action to check for unsupported functions * MWPW-122611 - [GH Action] Old browser function detection - add a Github action to check for unsupported functions * MWPW-122611 - [GH Action] Old browser function detection - add a Github action to check for unsupported functions --------- Co-authored-by: Aaron Mauchley <mauchley@adobe.com> removing display none from accordion (adobecom#433) Media & Z-Pattern updates - content margins and 2-5up grid support (adobecom#429) * updates to media to support section meta two-five ups * updated default margins * Added detail styles to text-transform:uppercase Removed redundant asside styles. * test coverate on image w/ out alt text --------- Co-authored-by: thi64146 <thi64146@adobe.com> Co-authored-by: Ryan Clayton <rgclayton@gmail.com> Update node to v18 (adobecom#440) MWPW-125458 - Adding chat icon (adobecom#439) Adding chat icon for bacom use Co-authored-by: Chris Peyer <chrischrischris@users.noreply.github.com> MWPW-124813 Prevent long breadcrumbs overlapping search (adobecom#434) MWPW-124277: Localize Gnav Sign In Link (adobecom#432) - Call decorateLinks for gnav sign in Resolves: MWPW-124277 add ignores similar to loc project details table markup updated removed console logs updated admin page to keep just the copy action removed copy files placeholder code clean up and loc config import fix cleanup rename app.js to ui.js floodgate content display updated cleanup removed window.projectDetail refactor
chrischrischris
pushed a commit
to adobecom/milo-target
that referenced
this pull request
May 22, 2023
…dobecom#429) * updates to media to support section meta two-five ups * updated default margins * Added detail styles to text-transform:uppercase Removed redundant asside styles. * test coverate on image w/ out alt text --------- Co-authored-by: thi64146 <thi64146@adobe.com> Co-authored-by: Ryan Clayton <rgclayton@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-123299
Test URLs:
Before Media
After Media
Before Z-Pattern
After Z-Pattern