Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Milo Text block automation scripts #115

Merged
merged 5 commits into from
May 5, 2023
Merged

Milo Text block automation scripts #115

merged 5 commits into from
May 5, 2023

Conversation

skumar09
Copy link
Contributor

@skumar09 skumar09 commented May 5, 2023

MWPW-130654: Text block automation test scripts

PR includes:

  • Automation test scripts for the following features of the Text block
    • Text
    • Text (intro)
    • Text (full width)
    • Text (full-width, large)
    • Text (long form, large)
    • Text (inset, large, m spacing)

@skumar09 skumar09 added run-milo-live run-milo-prod run test scripts on milo prod env @text Milo Text Block Tag labels May 5, 2023
amauch-adobe
amauch-adobe requested changes May 5, 2023
View reviewed changes
Copy link
Collaborator

@amauch-adobe amauch-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comments/quick questions, feel free to answer them inline with the PR. Looks great.

selectors/milo/text.block.page.js Outdated Show resolved Hide resolved
selectors/milo/text.block.page.js Show resolved Hide resolved
@skumar09 skumar09 requested a review from amauch-adobe May 5, 2023 20:05
amauch-adobe
amauch-adobe approved these changes May 5, 2023
View reviewed changes
Copy link
Collaborator

@amauch-adobe amauch-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@skumar09 skumar09 merged commit ffff820 into adobecom:main May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackySun9 JackySun9 JackySun9 approved these changes

@amauch-adobe amauch-adobe amauch-adobe approved these changes

@auniverseaway auniverseaway Awaiting requested review from auniverseaway

@rgclayton rgclayton Awaiting requested review from rgclayton

@Dli3 Dli3 Awaiting requested review from Dli3

@JFernandezAdobe JFernandezAdobe Awaiting requested review from JFernandezAdobe

Assignees
No one assigned
Labels
run-milo-live run-milo-prod run test scripts on milo prod env @text Milo Text Block Tag
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skumar09 @amauch-adobe @JackySun9 @nateekar