CC regression - accordion feature #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CC Merchtable block automation (JIra: MWPW-140978)
CC sticky promo bar, promo with close action automated test cases Jira : MWPW-140982, MWPW-142252
…eatures CC Regression automated cases for media rounded corners, breadcrumb features (MWPW-140976, MWPW-142543)
CC home page tabs, fragment reference , merch pod AU tests Jiras: https://jira.corp.adobe.com/browse/MWPW-143230 https://jira.corp.adobe.com/browse/MWPW-142599 https://jira.corp.adobe.com/browse/MWPW-143231
Key CC , CCT product pages sanity checks automation for EN https://jira.corp.adobe.com/browse/MWPW-146289
CC Tier1 locales production sanity tests https://jira.corp.adobe.com/browse/MWPW-146289
removed the lengthy URL
removed the space
removed tailing spaces from given lines
CC page Accordion features regression automated cases https://jira.corp.adobe.com/browse/MWPW-147151 https://jira.corp.adobe.com/browse/MWPW-147152 https://jira.corp.adobe.com/browse/MWPW-147153 https://jira.corp.adobe.com/browse/MWPW-147154
|
@sigadamvenkata could you fix the eslint warnings? |
|
@sigadamvenkata Do you only run your tests on chrome? |
|
Does CC have their own unique accordion block? @sigadamvenkata |
amauch-adobe
requested changes
Apr 23, 2024
tests/cc/accordion.test.js
Outdated
| test.beforeEach(async ({ page }) => { | ||
| accordion = new Accordion(page); | ||
| }); | ||
| // erify accordion showing up with authored question and answers and UI |
There was a problem hiding this comment.
Missing 'V' in Verify within comment.
tests/cc/accordion.test.js
Outdated
| await accordion.accordionQuestion1.click(); | ||
| expect(await accordion.accordexpanded).toBeTruthy(); | ||
| await accordion.firstQuestionLink.click(); | ||
| await page.waitForTimeout(1000); |
There was a problem hiding this comment.
As a recommendation I would look for a way to wait for an element on the subsequent page or it's load state to finish before checking the url since waiting for timeouts aren't very reliable since network or CI/CD pipeline issues could cause it to take longer than just a second.
|
@sigadamvenkata if you clone this from milo to cc, we might no need to do this, are you cloning the tests from milo? |
skumar09
approved these changes
Apr 24, 2024
corrected the typo
fixed indentations issue at line 14,15,16 Also removed wait from line number 81
|
@amauch-adobe made the changes mentioned by you. |
amauch-adobe
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC regression - accordion feature
https://jira.corp.adobe.com/browse/MWPW-147151
https://jira.corp.adobe.com/browse/MWPW-147152
https://jira.corp.adobe.com/browse/MWPW-147153
https://jira.corp.adobe.com/browse/MWPW-147154
test case report from local:
