Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add headerKey config for custom header config #131

Closed
wants to merge 1 commit into from
Closed

feature: Add headerKey config for custom header config #131

wants to merge 1 commit into from

Conversation

gaetansenn
Copy link

@gaetansenn gaetansenn commented May 6, 2019

Proposed changes

The idea is to add a custom headerKey to allow changing default header key used to get the token from basic, jwt, api scheme

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Commit for the documentation: https://github.com/cmty/docs/commit/347f2bd0411a37e37fbd6dbf2bcbd943c96411aa

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 88.98% when pulling 48f0552 on cmty:develop into 404a7ba on adonisjs:develop.

@stale
Copy link

stale bot commented Aug 17, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: Abandoned Dropped and not into consideration label Aug 17, 2020
@stale stale bot closed this Aug 24, 2020
@thetutlage thetutlage removed the Status: Abandoned Dropped and not into consideration label Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants