fix(lucid): add soft delete support to pair method #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thetutlage I had a go at fixing this one, not sure if this is the optimum place to check for soft deletes? If so I'll do the same for more methods |
thetutlage
reviewed
Apr 8, 2017
| @@ -464,8 +464,13 @@ methods.ids = function (target) { | |||
| * @return {Function} | |||
| */ | |||
| methods.pair = function (target) { | |||
| // console.log(target) | |||
There was a problem hiding this comment.
This the not the right way to do it. Instead we should apply all the global scopes when they exists. Same is done with fetch method.
|
Fixed in c394950 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the first part of #109