fix(commands): close database connection after commands

db:seed and migration:status gracefully close database connections
adonisjs · Jul 16, 2017 · 4ad9402 · 4ad9402
1 parent 5a93394
commit 4ad9402
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/src/Commands/Seed.js b/src/Commands/Seed.js
@@ -56,6 +56,9 @@ class Seed extends Command {
       this.success(`${this.icon('success')} seeded database successfully`)
     } catch (e) {
       this.error(e)
+    } finally {
+      const MigrationsRunner = this.migrations
+      new MigrationsRunner().database.close()
     }
   }
 }

diff --git a/src/Commands/Status.js b/src/Commands/Status.js
@@ -52,8 +52,6 @@ class Status extends Command {
       this.table(['Migration', 'Status'], response)
     } catch (e) {
       this.error(e)
-    } finally {
-      migrationsRunner.database.close()
     }
   }
 }

diff --git a/src/Migrations/index.js b/src/Migrations/index.js
@@ -158,6 +158,7 @@ class Migrations {
    */
   * status (files) {
     const migrate = yield this._diff(files, 'up')
+    this.database.close()
     return _.transform(files, function (result, file, name) {
       if (migrate.indexOf(name) > -1) {
         result[name] = 'N'