fix(modifier): ensure compatibility with ember-modifier v4 #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package.json
Outdated
| @@ -44,7 +44,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@embroider/addon-shim": "^0.50.2", | |||
| "ember-modifier": "^3.0.0" | |||
| "ember-modifier": "^3.2.7" | |||
There was a problem hiding this comment.
as ember-modifier@4.0.0 got published, let's include it in the range
Suggested change
| "ember-modifier": "^3.2.7" | |
| "ember-modifier": "^3.2.7 || ^4.0.0" |
|
@anehx we're running into the compatibility issue you've fixed here. Any chance you can move this forward? |
anehx
force-pushed
the
ember-modifier-deprecations
branch
from
665d5b7
to
9471789
Compare
|
@anehx Is there anything blocking this from being merged? I would be happy to help in any way I can. |
|
@tcjr @patrickberkeley I don't have any permissions on this repo so I can't really push this forward. Since I waited too long for a response we dropped |
|
@SergeAstapov Anything we can do to help merging this? 🙂 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts the
pikadaymodifier to use the newember-modifierAPI introduced inv3.2.0. I migrated the modifier using this guide here.