Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update osgi jar link #134

Merged
merged 1 commit into from
Dec 18, 2020
Merged

Update osgi jar link #134

merged 1 commit into from
Dec 18, 2020

Conversation

LongyuZhang
Copy link
Contributor

@LongyuZhang LongyuZhang commented Dec 18, 2020 •
edited
Loading

@LongyuZhang LongyuZhang marked this pull request as draft December 18, 2020 15:56
@karianna karianna added the enhancement New feature or request label Dec 18, 2020
@karianna karianna added this to the December 2020 milestone Dec 18, 2020
@LongyuZhang
Update osgi jar link
a67ec77 
- Update osgi jar link

Signed-off-by: Longyu Zhang <longyu.zhang@ibm.com>
@LongyuZhang LongyuZhang marked this pull request as ready for review December 18, 2020 21:04
@LongyuZhang
Copy link
Contributor Author

Test Links (Grinder_TKG):
jdk 11: xlinux 1039 aix 1040 zos 1042
jdk 8: xlinux 1043 aix 1044 win 1045

Download successfully with the updated link and sha:

12:09:04       [exec] downloading dependent third party jars to /home/jenkins/workspace/Grinder_TKG/openjdk-tests/TKG/../TKG/lib
12:09:04       [exec] downloading  https://repo1.maven.org/maven2/org/eclipse/platform/org.eclipse.osgi/3.16.100/org.eclipse.osgi-3.16.100.jar
12:09:04       [exec] --> file downloaded to /home/jenkins/workspace/Grinder_TKG/openjdk-tests/TKG/../TKG/lib/org.eclipse.osgi-3.16.100.jar
12:09:04       [exec] downloaded dependent third party jars successfully

@LongyuZhang
Copy link
Contributor Author

@llxia @renfeiw Could you review it? Thanks.

@sophia-guo
Copy link
Contributor

sophia-guo commented Dec 18, 2020 •
edited
Loading

Should test in openj9 be updated as tar name has been changed? https://github.com/eclipse/openj9/blob/master/test/functional/cmdLineTests/CDSAdaptorTest/cdsadaptortest.xml#L34

@LongyuZhang
Copy link
Contributor Author

Should test in openj9 be updated as tar name has been changed? https://github.com/eclipse/openj9/blob/master/test/functional/cmdLineTests/CDSAdaptorTest/cdsadaptortest.xml#L34

It is in another PR: eclipse-openj9/openj9#11520

renfeiw
renfeiw approved these changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@renfeiw renfeiw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LongyuZhang LongyuZhang mentioned this pull request Dec 18, 2020
Merged
@llxia
Copy link
Contributor

llxia commented Dec 18, 2020

I would suggest using a generic name (i.e., org.eclipse.osgi.jar) next time so that we do not need to update the name in multiple repos.

llxia
llxia approved these changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia llxia merged commit 9bc93c2 into adoptium:master Dec 18, 2020
@llxia
Copy link
Contributor

llxia commented Dec 18, 2020

https://ci.eclipse.org/openj9/job/test.getDependency/12611/ passed

@sophia-guo sophia-guo mentioned this pull request Dec 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llxia llxia llxia approved these changes

@renfeiw renfeiw renfeiw approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
December 2020
Development

Successfully merging this pull request may close these issues.
5 participants
@LongyuZhang @sophia-guo @llxia @renfeiw @karianna