Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove link of Checklist in the Banner #1186

Merged
merged 1 commit into from
Nov 26, 2022

Conversation

zdtsw
Copy link
Contributor

@zdtsw zdtsw commented Nov 23, 2022

From retro adoptium/adoptium#181 (comment) we will keep having release checklist but not mark it in the banner

Checklist
  • npm test passes
  • documentation is changed or added (if applicable)
  • permission has been obtained to add new logo (if applicable)
  • contribution guidelines followed here

@netlify
Copy link

netlify bot commented Nov 23, 2022

Deploy Preview for eclipsefdn-adoptium-v2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6a391ee
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium-v2/deploys/637e2bcb56cefb0008b1ca99
😎 Deploy Preview https://deploy-preview-1186--eclipsefdn-adoptium-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@zdtsw zdtsw changed the title Wenzhou/docs docs: remove link of Checklist in the Banner Nov 23, 2022
@zdtsw zdtsw marked this pull request as draft November 23, 2022 14:17
@zdtsw zdtsw marked this pull request as ready for review November 23, 2022 14:19
@tellison tellison enabled auto-merge (squash) November 24, 2022 11:42
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karianna
Copy link
Contributor

run rests

@karianna
Copy link
Contributor

Hmm, not sure how to fire off those checks again

@netlify
Copy link

netlify bot commented Nov 26, 2022

Deploy Preview for eclipsefdn-adoptium ready!

Name Link
🔨 Latest commit 8ecc5e2
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/6381aab0fe7bb4000876ab84
😎 Deploy Preview https://deploy-preview-1186--eclipsefdn-adoptium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@zdtsw
Copy link
Contributor Author

zdtsw commented Nov 26, 2022

Hmm, not sure how to fire off those checks again

i pushed a "git commit --amend" , running now

@tellison tellison merged commit 270d7f4 into adoptium:main Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants