Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert shuffle vendors #767

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Revert shuffle vendors #767

merged 1 commit into from
Jul 12, 2022

Conversation

tellison
Copy link
Contributor

Testing revert of #721

Checklist
  • npm test passes
  • documentation is changed or added (if applicable)
  • permission has been obtained to add new logo (if applicable)
  • contribution guidelines followed here

@netlify
Copy link

netlify bot commented Jul 12, 2022 •
edited
Loading

✅ Deploy Preview for eclipsefdn-adoptium-v2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b847b8d
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium-v2/deploys/62cd5ad0a70ab50008998042
😎 Deploy Preview https://deploy-preview-767--eclipsefdn-adoptium-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

zdtsw
zdtsw approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@zdtsw zdtsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sxa
sxa approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the basis that the test deploy seems to be working.

@sxa
Copy link
Member

sxa commented Jul 12, 2022

Fixes #770

@tellison tellison enabled auto-merge (squash) July 12, 2022 11:35
@tellison tellison merged commit 8a39940 into adoptium:main Jul 12, 2022
@tellison tellison mentioned this pull request Jul 12, 2022
Closed
@tellison tellison deleted the shuffle-revert branch July 12, 2022 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zdtsw zdtsw zdtsw approved these changes

@sxa sxa sxa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tellison @sxa @zdtsw