-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add openjdk.test.security in systemtest #453
Comments
Hmm I would have expected that the |
Thanks for your interest and suggestion @joeyleeeeeee97 ! If you are referring to security tests from the openjdk repository, we include them in the openjdk group already as the following test targets: jdk_security1 These are run as part of the top-level extended.openjdk target which we were running on the weekend (though it appears we may not have yet re-enabled from disabling for the July release). Example of a test job running those targets: https://ci.adoptopenjdk.net/view/Test_openjdk/job/Test_openjdk11_dragonwell_extended.openjdk_aarch64_linux/13/tapResults/. (JUnit results of same test run: https://ci.adoptopenjdk.net/view/Test_openjdk/job/Test_openjdk11_dragonwell_extended.openjdk_aarch64_linux/13/testReport/) In the top-level sanity.openjdk target, we include the jdk_tier1_cipher target which is applicable to jdk11+. If you are referring to other test material, can you point to it so we can consider adding it? Or perhaps you are suggesting we write some new tests. If we have a gap, then certainly that would be a good plan. Please help to take a look at what we currently include and we can see if any other material should be added. |
@smlambert Thanks for the suggestions, and yes! I am thinking of adding new tests. For example, 'I was using TLSv1.3 and on my app, does it work after migrating to OpenJDK? Please prove that." So after all we write a small app that mocks what they are using, and this kind of test I think might be useful I think this is some kind of 'system test' also. |
Sounds good re: defining the common user stories / patterns and augmenting our system tests - @joeyleeeeeee97 ! |
@smlambert https://github.com/joeyleeeeeee97/aqa-systemtest/blob/master/openjdk.test.security/doc/README.md My progress is about 60%. |
Ok great, thanks @joeyleeeeeee97 ! From my quick glance, it looks like a great start, I will only get a chance to look more closely after this first week of Sept release is complete. |
Overview
Security is an important part that contains runtime access control like SecurityManager, communication security protocols like TLS. Here I propose we add openjdk.test.security to cover this.
How is it implemented?
TLS communication tests. Personally I think this is important :)
SecurityManager (Maybe)
Remote login agent(Maybe)
The text was updated successfully, but these errors were encountered: