Update sytem stf project name

[sophia-guo]

System stf git repo name/project has changed to uppercase STF, to make it work on case-sensitive platforms we need to update the name accordingly. Otherwise we will get the following error

/home/runner/work/run-aqa/run-aqa/aqa-tests/system/common.xml:60: The directory /home/runner/work/run-aqa/run-aqa/aqa-tests/system/stf does not exist

For example it happened running github action on linux
https://github.com/adoptium/run-aqa/runs/3796240585?check_suite_focus=true

To fix it, the ${SYSTEMTEST_ROOT}/stf and ${SYSTEMTEST_DEST}/stf in https://github.com/adoptium/aqa-tests/blob/master/system/common.xml should be replaced by ${SYSTEMTEST_ROOT}/STF and ${SYSTEMTEST_DEST}/STF correspondingly. Note other stf in the comment or part of variable name or description should be keep as is. For example stf.build, stf.core, stf.sample, stf.load, stf_branch, etc.

For jenkins job "stf" in https://github.com/adoptium/aqa-tests/blob/master/buildenv/jenkins/JenkinsfileBase#L424 will also need to be updated to "STF".

[sophia-guo]

Looks like https://github.com/adoptium/STF may also need to update? I will take a look and see if the change is needed in STF repo.
https://github.com/adoptium/STF/blob/master/stf.build/scripts/stf_clone_make.bat#L16
https://github.com/adoptium/STF/blob/master/stf.build/scripts/stf_clone_make.sh#L17

Looks those are fine, just ignore this comment.

[abigailsleek]

I will like to assign this to myself.

[smlambert]

This issue is still available.

[abigailsleek]

Can I work on it as well?

On Fri, 8 Oct 2021 at 10:20 PM, Shelley Lambert ***@***.***> wrote: This issue is still available. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#2949 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHMKITMGJFCJ7OKACI6VSHTUF5OB7ANCNFSM5FMMYCTQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

-- Nneamaka Chalokwu

[smlambert]

Once a PR for the other issue is ready for review, you can pick up a new issue. We prefer the approach of take 1 issue, prepare a fix for it, push a PR for review, then take another issue, rather than working on multiple issues at once.

[abigailsleek]

Okay, will do so thank you.

On Sat, 9 Oct 2021 at 9:07 PM, Shelley Lambert ***@***.***> wrote: Once a PR for the other issue is ready for review, you can pick up a new issue. We prefer the approach of take 1 issue, prepare a fix for it, push a PR for review, then take another issue, rather than working on multiple issues at once. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#2949 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHMKITKIKVMC3FHKHJR2MYTUGCOGTANCNFSM5FMMYCTQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

-- Nneamaka Chalokwu

[Lovelynchristian]

I would love this to be assigned to me.

[keithc-ca]

It might be better to go the other way: update scripts to use a working directory based on the actual repo name (STF instead of stf).

[llxia]

@Lovelynchristian do you have any questions regarding this issue?

[Lovelynchristian]

No, I don't

…

On Mon, Oct 18, 2021, 8:57 PM Lan Xia ***@***.***> wrote: @Lovelynchristian <https://github.com/Lovelynchristian> do you have any questions regarding this issue? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2949 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASV2CKNAYGIAVFDQ7HJABLLUHR333ANCNFSM5FMMYCTQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[llxia]

@Lovelynchristian This fix is important as it affects GitHub PR testing. We would prefer to get this fix in asap. Is it possible to have PR created by the end of this Friday? Thanks

[Lovelynchristian]

@llxia I'm very sorry, I thought i could pull through with this issue . I'm working on another project currently. Please pardon me for all inconveniences.

[llxia]

No problem @Lovelynchristian . I will unassign you with this issue. Please feel free to pick up any other issues when you have time.

[xius666]

Can I take this?

[llxia]

Thanks @xius666

[sophia-guo]

Agreed #2949 (comment). There are multiple places in aqa-tests and aqa-systemtest are using as directoryVariable/stf/..... Setting a working directory based on the actual repo name (STF instead of stf) should make the job easier. For now we'd like this first be addressed.

Probably open a separate issue to improve this(Setting a working directory based on the actual repo name for STF). @Mesbah-Alam thoughts?