Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch api query back to AdoptOpenjdk for openj9 jdk #2950

Closed
sophia-guo opened this issue Oct 5, 2021 · 3 comments · Fixed by #2981
Closed

Switch api query back to AdoptOpenjdk for openj9 jdk #2950

sophia-guo opened this issue Oct 5, 2021 · 3 comments · Fixed by #2981
Assignees

Comments

@sophia-guo
Copy link
Contributor

Adoptium api can get the latest nightly builds, however it doesn't support openj9 jdk anymore. We should switch api back to AdoptOpenJDK for openj9 specifically.

We need to add a condition block for openj9 query for the the following blocks:
https://github.com/adoptium/aqa-tests/blob/master/get.sh#L226-L232

For hotspot jdk and testimage we keep using Adoptium. (Note, hotspot testimage is not available for jdk8)
For openj9 jdk and testimage we use https://api.adoptopenjdk.net/

Something like:

download_url="https://api.adoptium.net/v3/binary/latest/${JDK_VERSION}/${release_type}/${os}/${arch}/jdk/${JDK_IMPL}/${heap_size}/adoptium?project=jdk"
info_url="https://api.adoptium.net/v3/assets/feature_releases/${JDK_VERSION}/${release_type}?architecture=${arch}&heap_size=${heap_size}&image_type=jdk&jvm_impl=${JDK_IMPL}&os=${os}&project=jdk&vendor=eclipse"

if [ "$JDK_VERSION" != "8" ] && [ "$JDK_IMPL" != "openj9" ]; then
    download_url+=" https://api.adoptium.net/v3/binary/latest/${JDK_VERSION}/${release_type}/${os}/${arch}/testimage/${JDK_IMPL}/${heap_size}/adoptium?project=jdk"
    info_url+=" https://api.adoptium.net/v3/binary/latest/${JDK_VERSION}/${release_type}/${os}/${arch}/testimage/${JDK_IMPL}/${heap_size}/adoptium?project=jdk"
fi

if [ "$JDK_IMPL" == "openj9" ]; then
download_url="https://api.adoptopenjdk.net/v3/binary/latest/${JDK_VERSION}/${release_type}/${os}/${arch}/jdk/openj9/${heap_size}/adoptopenjdk https://api.adoptopenjdk.net/v3/binary/latest/${JDK_VERSION}/${release_type}/${os}/${arch}/testimage/openj9/${heap_size}/adoptopenjdk"
info_url="https://api.adoptopenjdk.net/v3/assets/feature_releases/${JDK_VERSION}/${release_type}?architecture=${arch}&heap_size=${heap_size}&image_type=jdk&jvm_impl=openj9&os=${os}&project=jdk&vendor=adoptopenjdk https://api.adoptopenjdk.net/v3/assets/feature_releases/${JDK_VERSION}/${release_type}?architecture=${arch}&heap_size=${heap_size}&image_type=testimage&jvm_impl=openj9&os=${os}&project=jdk&vendor=adoptopenjdk"
fi
@llxia
Copy link
Contributor

llxia commented Oct 6, 2021

Talked with @AdamBrousseau , we should add this back for openj9 for now. Once the Semeru API is up and running, we can update the URL link to point to the new API.

@julian55455
Copy link
Contributor

Can I work on this?

@julian55455
Copy link
Contributor

@sophia-guo @AdamBrousseau I need some reviews on this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants