Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jdk_svc_sanity and jdk_jdi has 32 duplicated testcases, which both include jdk_jdi_sanity #3993

Closed
sendaoYan opened this issue Sep 26, 2022 · 4 comments · Fixed by #4019
Closed

Comments

@sendaoYan
Copy link
Contributor

Describe the bug
jdk_svc_sanity and jdk_jdi has 32 duplicate testcases, which both include jdk_jdi_sanity

jdk_svc_sanity:

image

jdk_jdi:

image

jdk_svc_sanity include jdk_jdi_sanity:

image

jdk_jdi_sanity:

image

jdk_jdi:

image

duplicate testcases:

jdk_jdi_sanity.txt

Expected behavior
The sanity.openjdk and extended.openjdk test target has no any duplicate testcases.

@sendaoYan
Copy link
Contributor Author

Mine solution: delete jdk_jdi_sanity in jdk_svc_sanity:

diff --git a/openjdk/playlist.xml b/openjdk/playlist.xml
index 9dd53626..5e71eac5 100644
--- a/openjdk/playlist.xml
+++ b/openjdk/playlist.xml
@@ -1442,7 +1442,11 @@
        -exclude:$(Q)$(TEST_RESROOT)$(D)$(PROBLEM_LIST_FILE)$(Q) \
        ${FEATURE_PROBLEM_LIST_FILE} \
        ${VENDOR_PROBLEM_LIST_FILE} \
-       $(Q)$(JTREG_JDK_TEST_DIR):jdk_svc_sanity$(Q); \
+       $(Q)$(JTREG_JDK_TEST_DIR):jdk_management_sanity$(Q) \
+       $(Q)$(JTREG_JDK_TEST_DIR):jdk_instrument_sanity(Q) \
+       $(Q)$(JTREG_JDK_TEST_DIR):jdk_jmx_sanity(Q) \
+       $(Q)$(JTREG_JDK_TEST_DIR):jdk_jfr_sanity(Q) \
+       $(Q)$(JTREG_JDK_TEST_DIR):svc_tools_sanity(Q); \
        $(TEST_STATUS)</command>
                <versions>
                        <version>11+</version>

@smlambert
Copy link
Contributor

This approach seems reasonable.

@sophia-guo
Copy link
Contributor

jdk_jfr_sanity( also a subset of jdk_svc_sanity) and jdk_jfr have the exactly same issue. We may need to open an issue for that too.

@sendaoYan Is there a way to do a minus jdk_jdi_sanity from jdk_jdi instead of minus jdk_jdi_sanity from jdk_svc_sanity? jdk_svc_sanity is part of sanity level. The solution of #3993 (comment) will move jdk_jdi_sanity from sanity to extended. If the solution can keep the tests in same level that would be great.

@sendaoYan
Copy link
Contributor Author

sendaoYan commented Oct 8, 2022

jdk_jfr_sanity( also a subset of jdk_svc_sanity) and jdk_jfr have the exactly same issue. We may need to open an issue for that too.

@sendaoYan Is there a way to do a minus jdk_jdi_sanity from jdk_jdi instead of minus jdk_jdi_sanity from jdk_svc_sanity? jdk_svc_sanity is part of sanity level. The solution of #3993 (comment) will move jdk_jdi_sanity from sanity to extended. If the solution can keep the tests in same level that would be great.

I have no idea how to minus jdk_jdi_sanity from jdk_jdi in openjdk/playlist.xml.
The solution of #3993 (comment) is delete jdk_jdi_sanity from sanity. I think extended.openjdk may include some of the sanity tests(jdk_jdi include jdk_jdi_sanity), make sure there are no duplicate testcases as a whole.

sendaoYan added a commit to sendaoYan/aqa-tests that referenced this issue Oct 8, 2022
jdk_svc_sanity and jdk_jdi has 32 duplicate testcases, which both include jdk_jdi_sanity. So delete jdk_jdi_sanity from jdk_svc_sanity to avoid duplicate testcases.

Fixes: adoptium#3993
Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>
sendaoYan added a commit to sendaoYan/aqa-tests that referenced this issue Oct 8, 2022
jdk_svc_sanity and jdk_jdi has 32 duplicate testcases, which both include jdk_jdi_sanity. So delete jdk_jdi_sanity from jdk_svc_sanity to avoid duplicate testcases.

Fixes: adoptium#3993
Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>
sendaoYan added a commit to sendaoYan/aqa-tests that referenced this issue Oct 8, 2022
jdk_svc_sanity and jdk_jdi has 32 duplicate testcases, which both include jdk_jdi_sanity. So delete jdk_jdi_sanity from jdk_svc_sanity to avoid duplicate testcases.

Fixes: adoptium#3993
Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>
@sendaoYan sendaoYan changed the title jdk_svc_sanity and jdk_jdi has 32 duplicate testcases, which both include jdk_jdi_sanity jdk_svc_sanity and jdk_jdi has 32 duplicated testcases, which both include jdk_jdi_sanity Oct 8, 2022
llxia pushed a commit that referenced this issue Oct 11, 2022
)

jdk_svc_sanity and jdk_jdi has 32 duplicate testcases, which both include jdk_jdi_sanity. So delete jdk_jdi_sanity from jdk_svc_sanity to avoid duplicate testcases.

Fixes: #3993
Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants