Add mixed platforms #2087
Add mixed platforms #2087
Conversation
|
Thanks @keithc-ca |
buildenv/jenkins/openjdk_tests
Outdated
| 'arm_linux' : [ | ||
| 'SPEC' : 'linux_arm', | ||
| 'LABEL' : 'ci.role.test&&sw.os.linux&&hw.arch.aarch32', | ||
| 'LABEL' : 'ci.role.test&&sw.os.linux&&hw.arch.aarch32' |
There was a problem hiding this comment.
I would like to keep the trailing comma. This was added purposely
- if there is a new entry, this line will not change
- it prevents the error in the future
There was a problem hiding this comment.
It's not legal in json and looking at https://groovy-lang.org/syntax.html, there are no examples of lists with a comma after the last element. Apparently groovy made an exception, but I suggest that's a bad idea (and the practice wasn't applied consistently - there's no comma after the last element of PLATFORM_MAP).
There was a problem hiding this comment.
Leaving trailing commas simplifies the git history. If we merge this PR, all of those lines will be updated, and when we look for one line history, we will find this PR and not the reason for the line in the first place.
Please see the article https://time2hack.com/are-you-using-trailing-commas-in-your-javascript/
The git commits are much cleaner if we add an extra comma.
I understand that this is groovy code and not JavaScript, but the same logic applies.
Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
|
Commas added and rebased. |
|
Thanks @keithc-ca |
Needed by eclipse-openj9/openj9#11166.