Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AArch64 macOS: Exclude some MathLoadTest tests #3375

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

knn-k
Copy link
Contributor

@knn-k knn-k commented Feb 24, 2022

This commit excludes the following tests on AArch64 macOS for the time
being:

  • MathLoadTest_all_special_5m
  • MathLoadTest_bigdecimal_special_5m

Signed-off-by: KONNO Kazuhiro konno@jp.ibm.com

This commit excludes the following tests on AArch64 macOS for the time
being:

- MathLoadTest_all_special_5m
- MathLoadTest_bigdecimal_special_5m

Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
@@ -129,6 +129,10 @@
<comment>rtc 139897</comment>
<variation>Mode554</variation>
</disable>
<disable>
<comment>https://github.com/eclipse-openj9/openj9/issues/14590</comment>
<platform>aarch64_mac.*</platform>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use <platform>aarch64_mac</platform> without .*

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I need .* here because we only have aarch64_mac_xl build at the moment.

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smlambert smlambert merged commit 9647005 into adoptium:master Feb 25, 2022
@knn-k knn-k deleted the aarch64macos_playlist1 branch February 25, 2022 15:21
knn-k added a commit to knn-k/aqa-tests that referenced this pull request Jun 6, 2022
This commit enables some MathLoadTest tests on AArch64 macOS again.
They were excluded by adoptium#3375.

Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
sophia-guo pushed a commit that referenced this pull request Jun 8, 2022
This commit enables some MathLoadTest tests on AArch64 macOS again.
They were excluded by #3375.

Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants