Exclude jtreg testcase TestObjectDescription.java for jdk8 #4343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exclude jtreg testcase jdk/jfr/event/oldobject/TestObjectDescription.java for jdk8, which run timeout Fixes: adoptium#4342 Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>
karianna
approved these changes
Feb 15, 2023
smlambert
reviewed
Feb 15, 2023
Exclude jtreg testcase jdk/jfr/event/oldobject/TestObjectDescription.java for jdk8, which run timeout; dragonwell-project/dragonwell8#473 Fixes: adoptium#4342 Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>
smlambert
reviewed
Feb 18, 2023
There was a problem hiding this comment.
hi @sendaoYan - I've created an umbrella issue so we can go through all of the jdk_jfr testcases that are excluded and see what upstream test updates can be made to stabilize them. Suggesting to change your PR to use it, so you do not need to keep an open issue in your repo.
Exclude jtreg testcase jdk/jfr/event/oldobject/TestObjectDescription.java for jdk8, which run timeout; dragonwell-project/dragonwell8#473 Fixes: adoptium#4352 Signed-off-by: sendaoYan <yansendao.ysd@alibaba-inc.com>
OK, thanks |
smlambert
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exclude jtreg testcase jdk/jfr/event/oldobject/TestObjectDescription.java for jdk8, which run timeout
Fixes: #4342