Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jtreg/FFI] Enable the test suites in JDK21 #4713

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

ChengJin01
Copy link

@ChengJin01 ChengJin01 commented Aug 18, 2023

The changes enable all FFI test suites except
a few excluded tests in JDK21 given everything
specific to JEP442 (except the union support)
has been implemented, as specified at
eclipse-openj9/openj9#16951.

Fixes: #eclipse-openj9/openj9/issues/17399

Signed-off-by: ChengJin01 jincheng@ca.ibm.com

The changes enable all FFI test suites except
a few excluded tests in JDK21 given everything
specific to JEP442 (except the union support)
has been implemented.

Fixes: #eclipse-openj9/openj9/issues/17399

Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
@ChengJin01
Copy link
Author

There are two test suites excluded for the time being till these issues are resolved:
[1] TestByteBuffer.java (waiting for the backport fix on AIX from OpenJDK)
[2] TestHFA.java (requested a fix for corner cases on pLinux from libffi)

@ChengJin01
Copy link
Author

The FFI test suites were verified with the latest nightly builds on all supported platforms at
https://openj9-jenkins.osuosl.org/job/Grinder/2790/console (jdk_foreign)
https://openj9-jenkins.osuosl.org/job/Grinder/2799/console (jdk_lang)

@ChengJin01
Copy link
Author

Reviewer: @llxia
FYI: @ShelleyLambert, @tajila, @pshipton

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia llxia merged commit 67a4672 into adoptium:master Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants