-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openjdk: update hotspot targets #5367
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes generally look fine, but I know that @zzambers wanted to run additional tests before merging, so I will put a hold until he is ready.
More testing: x86-32_windows hotspot_compiler:
hotspot_gc:
17: 1 FAILURE
hotspot_runtime:
hotspot_serviceability:
|
ppc64_aix hotspot_sanity: hotspot_runtime:
hotspot_serviceability:
hotspot_gc: hotspot_compiler: |
I have done testing on other platforms and updated exclude lists. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the extra testing @zzambers !
This PR improves openjdk hotspot testing coverage ( see: #5316 ).
Changes:
hotspot_{compiler,gc,runtime,serviceability}
were changed from jdk 8,9 to 11+, flagless configuration and moved to dev level (except for hotspot_compiler)sanity/ExecuteInternalVMTests.java
(but on 8 almost all hotspot tests are ran by hotspot_jre target)hotspot_sanity
- runs very basicsanity
tests. (that's basically what disabled hotspot_* tests did on 8)jdk_compiler
- now replaced withhotspot_compiler
(which now also corresponds to test group name in openjdk)hotspot_serviceability_jvmti
- not needed anymore, tests are included inhotspot_serviceability
ASGCTBaseTest
->ASGCTBaseTest_j9
to indicate it is openj9 only (as in other openj9 targets)jvm_native_sanity
->hotspot_native_sanity
(so that it corresponds to test group name in openjdk)Testing:
So far tested only on x86-64_linux:
hotspot_sanity:
8: OK
11: OK
17: OK
21: OK
hotspot_compiler:
11: OK
17: OK
21: OK
hotspot_gc:
11: OK
17: OK
21: OK
hotspot_runtime:
11: OK
17: OK
21: 1 FAILURE
runtime/os/TestHugePageDecisionsAtVMStartup.java#THP_enabled.TestHugePageDecisionsAtVMStartup_THP_enabled
( could be missing support for old kernels (rhel-7) by THP code, see e.g.: JDK-8324580 )
hotspot_serviceability:
11: OK
17: OK
21: OK