Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using custom target for rerun builds #5382

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Using custom target for rerun builds #5382

merged 3 commits into from
Jun 19, 2024

Conversation

sophia-guo
Copy link
Contributor

@sophia-guo sophia-guo commented Jun 11, 2024 •
edited
Loading

Close #5241 fix #5388

@sophia-guo sophia-guo marked this pull request as draft June 11, 2024 20:55
@sophia-guo
Copy link
Contributor Author

#5241 - rerun job custom_target can be setup correctly

@sophia-guo
Copy link
Contributor Author

Feels like its hard to find lots of failures unless run the whole set ( extended) without problemlist. Tried some most succeed.
https://ci.adoptium.net/job/Grinder/10348/

Wait this on window32 https://ci.adoptium.net/job/Grinder/10351/
and aix jdk17 https://ci.adoptium.net/job/Grinder/10354/

@sophia-guo
Copy link
Contributor Author

sophia-guo commented Jun 12, 2024 •
edited
Loading

Failed tests belong to different custom target failed targets will be used in rerun job instead https://ci.adoptium.net/job/Grinder/10359/
Failed tests belong to one custom target Custom Target will be used in rerun job https://ci.adoptium.net/job/Grinder/10344/

Failed tests belong to one custom target and test cases number exceeds the limitation ( using 10 as limitation)
https://ci.adoptium.net/job/Grinder/10375/console - test target is not **_custom , works.
https://ci.adoptium.net/job/Grinder/10374/ - test target is **_custom, custom_target is empty and passed using the default custom target, need to consider this situation.

update https://ci.adoptium.net/job/Grinder/10388/ -( using 3 as test number limitation)

@sophia-guo
Using custom target for rerun builds
899ed4b 
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
@sophia-guo sophia-guo force-pushed the rerunTarget branch 2 times, most recently from b89c4b7 to 13e843e Compare June 13, 2024 13:23
@sophia-guo
Leave CUSTOM_TARGET as is if custom testcases can't work for rerun
40e4d23 
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
@sophia-guo sophia-guo mentioned this pull request Jun 13, 2024
Closed
@sophia-guo sophia-guo marked this pull request as ready for review June 13, 2024 17:49
@sophia-guo sophia-guo self-assigned this Jun 13, 2024
@sophia-guo
Comment for selected test cases size
7b19bba 
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
LongyuZhang
LongyuZhang approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

smlambert
smlambert approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - we may want to cherrypick this change to v1.0.2-release branch which will be used for July release

@smlambert smlambert merged commit e714f85 into adoptium:master Jun 19, 2024
2 checks passed
sophia-guo added a commit to sophia-guo/openjdk-tests that referenced this pull request Jun 19, 2024
@sophia-guo
Using custom target for rerun builds (adoptium#5382)
a39799d 
* Using custom target for rerun builds

Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>

* Leave CUSTOM_TARGET as is if custom testcases can't work for rerun

Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>

* Comment for selected test cases size

Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>

---------

Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
@sophia-guo sophia-guo mentioned this pull request Jun 19, 2024
Merged
LongyuZhang pushed a commit that referenced this pull request Jun 19, 2024
@sophia-guo
Using custom target for rerun builds (#5382) (#5398)
b1cc88e 
* Using custom target for rerun builds



* Leave CUSTOM_TARGET as is if custom testcases can't work for rerun



* Comment for selected test cases size



---------

Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LongyuZhang LongyuZhang LongyuZhang approved these changes

@smlambert smlambert smlambert approved these changes

Assignees

@sophia-guo sophia-guo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rerun job fails if parents job with *_custom as target Using custom target for rerun jobs
3 participants
@sophia-guo @smlambert @LongyuZhang