Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JDK8 restriction for alpine library path #5430

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

Haroon-Khel
Copy link
Contributor

@Haroon-Khel Haroon-Khel commented Jul 11, 2024

Testing to see if this fixes #5425 and adoptium/infrastructure#3529

@Haroon-Khel
Copy link
Contributor Author

Running jdk 11 tests on test-docker-alpine320-x64-1 which is using jdk21 as its default https://ci.adoptium.net/job/Grinder/10571/console

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 330 and 623 need the same change (623 will specifically resolve the problem during the compile phase)

Verified at https://ci.adoptium.net/job/Grinder/10581/console

@Haroon-Khel
Copy link
Contributor Author

Haroon-Khel commented Jul 11, 2024

AQA test pipeline for JDK8 11 17 and 21 on all of our x64 Alpine boxes to make sure other JDKs arent affected
https://ci.adoptium.net/job/AQA_Test_Pipeline/336/console

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AQA test pipeline for JDK8 11 17 and 21 on all of our x64 Alpine boxes to make sure other JDKs arent affected https://ci.adoptium.net/job/AQA_Test_Pipeline/336/console

Thanks - granting my approval on the condition that those tests pass successfully.

@Haroon-Khel
Copy link
Contributor Author

Its having trouble building the downstream jobs off my branch, https://ci.adoptium.net/job/Test_openjdk8_hs_special.functional_x86-64_alpine-linux/112/console for example

hudson.plugins.git.GitException: Command "git fetch --tags --force --progress --prune -- origin +refs/heads/alpine.library:refs/remotes/origin/alpine.library" returned status code 128:
stdout: 
stderr: fatal: couldn't find remote ref refs/heads/alpine.library

Its using origin in place of my fork. My fork and branch have been passed to the job in the parameters section

@Haroon-Khel
Copy link
Contributor Author

Haroon-Khel commented Jul 11, 2024

Ill run them as grinders in the meantime, just the extended tests
jdk8 https://ci.adoptium.net/job/Grinder/10582/console
jdk11 https://ci.adoptium.net/job/Grinder/10583/console
jdk17 https://ci.adoptium.net/job/Grinder/10584/console
jdk21 https://ci.adoptium.net/job/Grinder/10585/console

And ive changed the default jdk on our x64 alpine boxes back to 21 (ref adoptium/infrastructure#3529 (comment))

@sxa
Copy link
Member

sxa commented Jul 11, 2024

Its using origin in place of my fork. My fork and branch have been passed to the job in the parameters section

Interesting - I hit a similar issue recently too - maybe post in #aqa-tests to see if anyone can explain/mitigate it? Can't think why Grinder would be different but I think that's what I experienced too.

@Haroon-Khel
Copy link
Contributor Author

Each of the grinders compiled and were built fine, other jdks have not been affected. This pr can be merged

Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Haroon-Khel - can you cherrypick this PR to the v1.0.2-release branch as well?

@smlambert smlambert merged commit 4779b26 into adoptium:master Jul 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JDK11 alpine-linux failures
3 participants