-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove JDK8 restriction for alpine library path #5430
Conversation
Running jdk 11 tests on test-docker-alpine320-x64-1 which is using jdk21 as its default https://ci.adoptium.net/job/Grinder/10571/console |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines 330 and 623 need the same change (623 will specifically resolve the problem during the compile phase)
Verified at https://ci.adoptium.net/job/Grinder/10581/console
AQA test pipeline for JDK8 11 17 and 21 on all of our x64 Alpine boxes to make sure other JDKs arent affected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AQA test pipeline for JDK8 11 17 and 21 on all of our x64 Alpine boxes to make sure other JDKs arent affected https://ci.adoptium.net/job/AQA_Test_Pipeline/336/console
Thanks - granting my approval on the condition that those tests pass successfully.
Its having trouble building the downstream jobs off my branch, https://ci.adoptium.net/job/Test_openjdk8_hs_special.functional_x86-64_alpine-linux/112/console for example
Its using |
Ill run them as grinders in the meantime, just the extended tests And ive changed the default jdk on our x64 alpine boxes back to 21 (ref adoptium/infrastructure#3529 (comment)) |
Interesting - I hit a similar issue recently too - maybe post in #aqa-tests to see if anyone can explain/mitigate it? Can't think why Grinder would be different but I think that's what I experienced too. |
Each of the grinders compiled and were built fine, other jdks have not been affected. This pr can be merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @Haroon-Khel - can you cherrypick this PR to the v1.0.2-release branch as well?
Testing to see if this fixes #5425 and adoptium/infrastructure#3529