Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for building RISC-V JDK17 natively from openjdk/jdk-sandbox #178

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

sxa
Copy link
Member

@sxa sxa commented Jul 7, 2021

I've left --with-native-debug-symbols=none and --custom-cacerts false in here for now purely to speed up the builds (particuarly since it won't be GA for a while - obviously both can be removed later if proven to work in a timely manner that doesn't slow the pipelines too badly) and hopefully once a conclusion on the VARIANT/VENDOR proposal is reached we can remove --disable-adopt-branch-safety but this will allow us to produce JDK17.

Note that the builds produced by this are currently likely to have a prereq of glibc2.31 for now (the version in Debian Sid) which is later than the other Linux builds we produce, but earlier than the glibc2.32 shipped with Fedora 33 (the other populate distribution for this platform).

@sxa sxa self-assigned this Jul 7, 2021
@github-actions
Copy link

github-actions bot commented Jul 7, 2021

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), I require an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.

@karianna karianna added this to the June 2021 milestone Jul 7, 2021
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sxa
Copy link
Member Author

sxa commented Jul 7, 2021

Fixes adoptium/temurin-build#2625

@sxa
Copy link
Member Author

sxa commented Jul 7, 2021

NOTE: Will hold off on merging pending the completion of test builds at https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk17/job/jdk17-linux-riscv64-hotspot/ which will likely take a few hours

@sxa
Copy link
Member Author

sxa commented Jul 7, 2021

run tests

@sxa sxa requested a review from andrew-m-leonard July 7, 2021 12:16
@eclipse-temurin-bot
Copy link
Collaborator

🟠 PR TESTER RESULT 🟠

❎ Some pipelines failed or the job was aborted! ❎
See the pipeline-build-check below for more information...

@sxa
Copy link
Member Author

sxa commented Jul 7, 2021

JDK18 pipeline test seemed to fail but I don't believe that is specific to this PR:

13:26:29  Compiling 229 files for BUILD_jdk.javadoc.interim
13:26:35  warning: unknown enum constant Feature.SEALED_CLASSES
13:26:35  warning: unknown enum constant Feature.SEALED_CLASSES
13:26:35  error: warnings found and -Werror specified
13:26:35  1 error
13:26:35  2 warnings
13:26:35  CompileInterimLangtools.gmk:97: recipe for target '/home/jenkins/workspace/build-scripts-pr-tester/build-test/jobs/jdk/jdk-linux-x64-hotspot/workspace/build/src/build/linux-x86_64-server-release/buildtools/interim_langtools_modules/java.compiler.interim

@sxa
Copy link
Member Author

sxa commented Jul 7, 2021

https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk17/job/jdk17-linux-riscv64-hotspot/5/console is running through ok - that is a temporary job created by me that will be superceded by an auto-generated one when this is merged.

@sxa
Copy link
Member Author

sxa commented Jul 7, 2021

@andrew-m-leonard Can you check that my assertion in the JD18 comment 2 above this one is valid [EDIT: Looks like some of the normal nightly JDK18s are failing with the same problem, so it definitely seems valid!] and if so approve please if you're ok with this change?

Copy link
Contributor

@andrew-m-leonard andrew-m-leonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@karianna
Copy link
Contributor

karianna commented Jul 8, 2021

All of the 18 builds failed with:

=== Output from failing command(s) repeated here ===
13:47:48  * For target buildtools_interim_langtools_modules_java.compiler.interim__the.BUILD_java.compiler.interim_batch:
13:47:48  warning: unknown enum constant Feature.SEALED_CLASSES
13:47:48  warning: unknown enum constant Feature.SEALED_CLASSES
13:47:48  error: warnings found and -Werror specified
13:47:48  1 error
13:47:48  2 warnings

However, that's a separate issue so merging this.

@karianna
Copy link
Contributor

karianna commented Jul 8, 2021

https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk17/job/jdk17-linux-riscv64-hotspot/5/console is running through ok - that is a temporary job created by me that will be superceded by an auto-generated one when this is merged.

Autogenerated one built OK but failed in a subsequent pipeline stage but that looks environmental https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk17/job/jdk17-linux-riscv64-hotspot/6/console

@karianna karianna merged commit 73e5d0a into adoptium:master Jul 8, 2021
AdamBrousseau added a commit to AdamBrousseau/ci-jenkins-pipelines that referenced this pull request Sep 19, 2023
Reverts CUDA9 end of support temp workaround
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants