-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for building RISC-V JDK17 natively from openjdk/jdk-sandbox #178
Conversation
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), I require an admin to post |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
NOTE: Will hold off on merging pending the completion of test builds at https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk17/job/jdk17-linux-riscv64-hotspot/ which will likely take a few hours |
run tests |
🟠 PR TESTER RESULT 🟠❎ Some pipelines failed or the job was aborted! ❎ |
JDK18 pipeline test seemed to fail but I don't believe that is specific to this PR:
|
https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk17/job/jdk17-linux-riscv64-hotspot/5/console is running through ok - that is a temporary job created by me that will be superceded by an auto-generated one when this is merged. |
@andrew-m-leonard Can you check that my assertion in the JD18 comment 2 above this one is valid [EDIT: Looks like some of the normal nightly JDK18s are failing with the same problem, so it definitely seems valid!] and if so approve please if you're ok with this change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
All of the 18 builds failed with:
However, that's a separate issue so merging this. |
Autogenerated one built OK but failed in a subsequent pipeline stage but that looks environmental https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk17/job/jdk17-linux-riscv64-hotspot/6/console |
Reverts CUDA9 end of support temp workaround
I've left
--with-native-debug-symbols=none
and--custom-cacerts false
in here for now purely to speed up the builds (particuarly since it won't be GA for a while - obviously both can be removed later if proven to work in a timely manner that doesn't slow the pipelines too badly) and hopefully once a conclusion on theVARIANT
/VENDOR
proposal is reached we can remove--disable-adopt-branch-safety
but this will allow us to produce JDK17.Note that the builds produced by this are currently likely to have a prereq of glibc2.31 for now (the version in Debian Sid) which is later than the other Linux builds we produce, but earlier than the glibc2.32 shipped with Fedora 33 (the other populate distribution for this platform).