update: remove aarch32 jdk8 from release-pipeline default setting #525
Conversation
- we have a later arrival scmReference tag and need extra input - good to manually trigger that release by sharing the same pipelin - make additionalConfigureArgs only set for jdk11+, default to ''
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
github-actions
bot
added
generation
| @@ -90,6 +90,10 @@ node('worker') { | |||
| config.put('defaultsJson', DEFAULTS_JSON) | |||
| config.put('adoptDefaultsJson', ADOPT_DEFAULTS_JSON) | |||
|
|
|||
| if(${javaVersion} != "8") { // for jdk11+, need extra config args to pass down | |||
There was a problem hiding this comment.
Maybe that should be >= 11?
I have a draft PR https://github.com/adoptium/temurin-build/pull/3159/files for all the changes we make for next release. |
docs will be merged before 2023 Jan release as new instruction of how to generate/use/trigger release pipelines. |
some more for the release pipeline
- do not have aarch32 in the same batch of build by release-openjdk8-pipeline due to different scmReference
- good to manually trigger that release by sharing the same pipeline with other jdk8 targets
- make additionalConfigureArgs only set for jdk11+, default to ' '
Ref: #514