Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unixPb: Link libffi.so.4 to libffi.so.6 in SLES12 s390x dockerfile #3037

Merged
merged 3 commits into from
May 17, 2023

Conversation

Haroon-Khel
Copy link
Contributor

@Haroon-Khel Haroon-Khel commented Apr 18, 2023

  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

ref #3026

Needed on sles 12 s390x to avoid this error on smoke tests

15:38:03  Run /home/jenkins/workspace/build-scripts/jobs/jdk8u/jdk8u-linux-s390x-temurin_SmokeTests/openjdkbinary/j2sdk-image/bin/java -version
15:38:03  =JAVA VERSION OUTPUT BEGIN=
15:38:03  Error: dl failure on line 894
15:38:03  Error: failed /home/jenkins/workspace/build-scripts/jobs/jdk8u/jdk8u-linux-s390x-temurin_SmokeTests/openjdkbinary/j2sdk-image/jre/lib/s390x/server/libjvm.so, because libffi.so.6: cannot open shared object file: No such file or directory

After the link is in place, the smoke test passes https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-linux-s390x-temurin_SmokeTests/182/console

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

@Haroon-Khel Haroon-Khel changed the title Dockerstatic: Link libffi.so.4 to libffi.so.6 in SLES12 Dockerstatic: Link libffi.so.4 to libffi.so.6 in SLES12 s390x dockerfile Apr 18, 2023
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correction: Can you update the commit to have a suitable prefix please

@Haroon-Khel Haroon-Khel changed the title Dockerstatic: Link libffi.so.4 to libffi.so.6 in SLES12 s390x dockerfile unixPb: Link libffi.so.4 to libffi.so.6 in SLES12 s390x dockerfile Apr 18, 2023
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth adding a comment as to why?

@sxa sxa requested a review from steelhead31 May 17, 2023 11:31
@Haroon-Khel
Copy link
Contributor Author

/thaw

@github-actions github-actions bot added docker and removed docker labels May 17, 2023
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot dismissed their stale review May 17, 2023 12:42

Pull Request unblocked - code freeze is over.

@Haroon-Khel Haroon-Khel merged commit d977430 into adoptium:master May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants