Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unixPb: Skip MacOS package upgrade on 10.15 and under #3045

Merged
merged 3 commits into from
May 3, 2023

Conversation

Haroon-Khel
Copy link
Contributor

@Haroon-Khel Haroon-Khel commented May 3, 2023

  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

10.15 has been out of support for some time now, https://endoflife.date/macos

TASK [Common : Upgrade installed packages] *************************************
fatal: [test-macstadium-macos1015-x64-1]: FAILED! => {"changed": false, "msg": "Warning: You are using macOS 10.15.\nWe (and Apple) do not provide support for this old version.\nIt is expected behaviour that some formulae will fail to build in this old version.\nIt is expected behaviour that Homebrew will be buggy and slow.\nDo not create any issues about this on Homebrew's GitHub repositories.\nDo not create any issues even if you think this message is unrelated.\nAny opened issues will be immediately closed without response.\nDo not ask for help from Homebrew or its maintainers on social media.\nYou may ask for help in Homebrew's discussions but are unlikely to receive a response.\nTry to figure out the problem yourself and submit a fix as a pull request.\nWe will review it but may or may not accept it.\n\nError: Your Xcode (10.3) is too outdated.\nPlease update to Xcode 12.4 (or delete it).\nXcode can be updated from the App Store."}

This task needs to be skipped on macos boxes that are 10.15 and under until we can provide a patching solution ourselves or upgrade the machines, I am in favour of the latter.

I've added the -y flag to the cask update command because it hangs on a y/N prompt. This must be new, I cant recall having this problem before.

@Haroon-Khel
Copy link
Contributor Author

I want the macos pr check to complete before addressing the linter failures https://github.com/adoptium/infrastructure/actions/runs/4873596036/jobs/8693393742?pr=3045

Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants