Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inventory: Correct the OS for dockerhost skytap machine #3163

Merged
merged 1 commit into from
Aug 24, 2023
Merged

inventory: Correct the OS for dockerhost skytap machine #3163

merged 1 commit into from
Aug 24, 2023

Conversation

Haroon-Khel
Copy link
Contributor

@Haroon-Khel Haroon-Khel commented Aug 14, 2023 •
edited
Loading

  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly
root@dockerhost-skytap-ubuntu2004-ppc64le-1:~# cat /etc/os-release 
NAME="Ubuntu"
VERSION="20.04.6 LTS (Focal Fossa)"

Incorrectly named 2204 when its OS is 2004

sxa
sxa requested changes Aug 14, 2023
View reviewed changes
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clicked too soon - can you add inventory: as a prefix on the commit message please?

@github-actions github-actions bot added docker and removed docker labels Aug 23, 2023
@Haroon-Khel Haroon-Khel requested a review from sxa August 23, 2023 15:49
@Haroon-Khel Haroon-Khel merged commit 66fb741 into adoptium:master Aug 24, 2023
5 checks passed
@Haroon-Khel Haroon-Khel deleted the update.skytap.inventory branch August 24, 2023 11:08
@steelhead31 steelhead31 mentioned this pull request Oct 6, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdams gdams gdams approved these changes

@sxa sxa sxa approved these changes

@karianna karianna karianna approved these changes

Assignees
No one assigned
Labels
ansible docker provider:skytap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Haroon-Khel @karianna @sxa @gdams