-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unixPB: Add an optional role for performance tools #3194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.
If this pull request needs to be merged during the release cycle then please comment /merge
and a PMC member will be able to remove the block.
If the code freeze is over you can remove this block by commenting /thaw
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noting that this is optional by virtue of not being included in the top level main.yml. To activate this you'd need to use a modified version with this new role included.
Sorry you haven't had any response to your post int he infrastructure channel looking for reviews here. I don't like doing this generally but under the circumstances I'll tag a few people who may wish to review it :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just need to resolve those failing checks if possible (probably unrelated, but still) |
They are failing as we havent ( and wont for JDK21+35 at least! ) be publishing the ppc64le distribution(and others), so they cant find the files to publish.. I've tagged you in the slack discussion. If we can get this merged, we can push the other installers up to artifactory. |
Friendly bump on this. |
I was just going through the PRs this morning :-) I'm happy to merge ont he basis that it doesn't impact anything else and so the failing checks are unrelated. |
/thaw |
Pull Request unblocked - code freeze is over.
Fixes: #3181
Adds an optional role for installing gdb, perf, nmon and valgrind on Ubuntu, CentOS, Rhel & SLES machines.
Checklist