Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unixPB: Add an optional role for performance tools #3194

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

aswinkr77
Copy link
Contributor

@aswinkr77 aswinkr77 commented Sep 25, 2023

Fixes: #3181

Adds an optional role for installing gdb, perf, nmon and valgrind on Ubuntu, CentOS, Rhel & SLES machines.

Checklist
  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that this is optional by virtue of not being included in the top level main.yml. To activate this you'd need to use a modified version with this new role included.

@sxa
Copy link
Member

sxa commented Oct 12, 2023

Sorry you haven't had any response to your post int he infrastructure channel looking for reviews here. I don't like doing this generally but under the circumstances I'll tag a few people who may wish to review it :-)

@steelhead31 @Haroon-Khel @karianna

Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karianna
Copy link
Contributor

Just need to resolve those failing checks if possible (probably unrelated, but still)

@steelhead31
Copy link
Contributor

Just need to resolve those failing checks if possible (probably unrelated, but still)

They are failing as we havent ( and wont for JDK21+35 at least! ) be publishing the ppc64le distribution(and others), so they cant find the files to publish.. I've tagged you in the slack discussion. If we can get this merged, we can push the other installers up to artifactory.

@AdamBrousseau
Copy link
Contributor

Friendly bump on this.

@sxa
Copy link
Member

sxa commented Nov 2, 2023

Friendly bump on this.

I was just going through the PRs this morning :-) I'm happy to merge ont he basis that it doesn't impact anything else and so the failing checks are unrelated.

@sxa
Copy link
Member

sxa commented Nov 2, 2023

/thaw

@github-actions github-actions bot dismissed their stale review November 2, 2023 10:49

Pull Request unblocked - code freeze is over.

@sxa sxa merged commit 4397454 into adoptium:master Nov 2, 2023
7 of 10 checks passed
@aswinkr77 aswinkr77 deleted the performance-tools branch January 5, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ansible request for Debuggers and Profilers in Linux Machines
6 participants