Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unixpb: Add Xcode11 installation tasks to Unix playbook #3197

Merged
merged 10 commits into from
Nov 16, 2023

Conversation

Haroon-Khel
Copy link
Contributor

@Haroon-Khel Haroon-Khel commented Sep 26, 2023

  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

ref #2536

Xcode11.7 is required on m1 mac machines in order to cross compile x64 jdk8

Our usual method of installing xcode using xcversion is no longer supported https://github.com/xcpretty/xcode-install/blob/master/MIGRATION.md and is causing errors when I use it to install xcode11.7, see #2536 (comment)

xcodes is another tool used to install different versions of xcode but I think it is dependent on Xcode13 which I believe requires macOS 11.3+ (our M1 machines are 11.0)

@Haroon-Khel Haroon-Khel changed the title Xcode11 unixpb: Add Xcode11 installation tasks to Unix playbook Sep 26, 2023
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would ideally want to ensure that if the vendor_files is not available then this does not cause a playbook failure (other people using our playbooks may not have it available). We should have some way to trap this (May be telling people to use a skip-tags option for the role telling people to install it manually, or just warning and continuing. Or maybe we should abort if the adoptopenjdk tag is not skipped)

@Haroon-Khel
Copy link
Contributor Author

The transfer process takes around 40mins. The binary is 7.6G.

And this may be due to timeout reasons, but after the transfer is complete ansible hangs. It hung for about 30mins before I interrupted the execution. I'll test to see if AWX shows the same behaviour

@Haroon-Khel
Copy link
Contributor Author

Haroon-Khel commented Sep 27, 2023

@Haroon-Khel
Copy link
Contributor Author

Tested this pr on test-macstadium-macos11-arm64-1. Works as expected

@Haroon-Khel
Copy link
Contributor Author

Running from AWX, the transfer takes the same time as running it from my machine, around 40mins. I dont think this is too bad as we are not seeing timeout errors

@karianna karianna requested a review from sxa September 30, 2023 02:53
@Haroon-Khel
Copy link
Contributor Author

I've rolled out xcode11.7 onto the 4 arm64 mac machines

@sxa
Copy link
Member

sxa commented Oct 2, 2023

Running from AWX, the transfer takes the same time as running it from my machine, around 40mins. I dont think this is too bad as we are not seeing timeout errors

Yeah that's fine since it's a one off and won't happen on subsequent runs of the playbook :-)

@gdams
Copy link
Member

gdams commented Nov 16, 2023

I'm going to go ahead and push this as it's blocking my Orka review

@gdams gdams merged commit a1c45af into adoptium:master Nov 16, 2023
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants