Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unixPb: Switch back to default xcode before running Macos playbook #3250

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

Haroon-Khel
Copy link
Contributor

@Haroon-Khel Haroon-Khel commented Nov 14, 2023

  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

ref #3249 (comment)

Brew update hits error if selected xcode is outdated

Error: Your Xcode (11.7 => /Applications/Xcode-11.7.app/Xcode.app/Contents/Developer) is too outdated.\n
Please update to Xcode 13.2.1 (or delete it).\nXcode can be updated from the App Store.\n
\nError: Your Command Line Tools are too outdated.\nUpdate them from Software Update in System Preferences.\n
\nIf that doesn't show you any updates, run:\n

@Haroon-Khel
Copy link
Contributor Author

Haroon-Khel commented Nov 14, 2023

Works as expected https://awx2.adoptopenjdk.net/#/jobs/playbook/2137?job_search=page_size:20;order_by:-finished;not__launch_type:sync

Still hits an error that is accounted for in #3249 (comment) but the default command line tools xcode is selected before continuing

@Haroon-Khel
Copy link
Contributor Author

ping @steelhead31 @sxa for review

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this cause any problems on the first invocation of a playbook on a new machine (e.g. if xcode has not yet been installed)?

@Haroon-Khel
Copy link
Contributor Author

Haroon-Khel commented Nov 28, 2023

Will this cause any problems on the first invocation of a playbook on a new machine (e.g. if xcode has not yet been installed)?

I'm certain command line tools gets installed when homebrew is installed, since we do not have a specific role for its install (the Xcode task installs xcode not command line tools)

https://mac.install.guide/commandlinetools/3.html#:~:text=If%20you%20haven't%20already,a%202021%20Mac%20M1%20Mini.

If you haven't already installed XCode Command Line Tools, you'll see a message that "The XCode Command Line Tools will be installed." Press return to continue when prompted by the Homebrew installation script.

So it makes sense to place the sudo xcode-select --switch / after the brew install

@Haroon-Khel Haroon-Khel merged commit 873460a into adoptium:master Dec 6, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants