Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: New dockernode.yml playbook to automate deployment of docker static containers #3390

Merged
merged 26 commits into from
Feb 15, 2024

Conversation

Haroon-Khel
Copy link
Contributor

@Haroon-Khel Haroon-Khel commented Feb 13, 2024

  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

ref #3370

New playbook added dockernode.yml which will deploy any number of specified containers onto a chosen dockerhost machine. Example usage: (will add to docs)

ansible-playbook AdoptOpenJDK_Unix_Playbook/dockernode.yml -t deploy -e "docker_images=u2204,alp314,deb11"

The deploy tag must be specified if the user wants to deploy a container. The docker_images variable will contain a list of chosen OSs for which we have dockerfiles (error is handled when dockerfile does not exist).

I am testing this at the moment in awx. Once successful we can remove the container build and deploy functionality in https://github.com/adoptium/infrastructure/blob/master/ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/DockerStatic/tasks/main.yml and leave the dockerhost.yml playbook for setting up dockerhost machines only, and use the new dockernode.yml playbook for deploying containers

@github-actions github-actions bot added docker and removed docker labels Feb 13, 2024
@Haroon-Khel Haroon-Khel self-assigned this Feb 13, 2024
@github-actions github-actions bot added docker and removed docker labels Feb 13, 2024
@github-actions github-actions bot added docker and removed docker labels Feb 14, 2024
@github-actions github-actions bot added docker and removed docker labels Feb 14, 2024
@github-actions github-actions bot added docker and removed docker labels Feb 14, 2024
@github-actions github-actions bot added docker and removed docker labels Feb 14, 2024
@github-actions github-actions bot added docker and removed docker labels Feb 14, 2024
@github-actions github-actions bot added docker and removed docker labels Feb 14, 2024
@github-actions github-actions bot added docker and removed docker labels Feb 14, 2024
@github-actions github-actions bot added docker and removed docker labels Feb 14, 2024
@Haroon-Khel
Copy link
Contributor Author

The changes work

69e6c452d007   aqa_u2204      "/usr/sbin/sshd -D"   7 minutes ago   Up 7 minutes   0.0.0.0:32769->22/tcp, :::32769->22/tcp   U2204.32769

@Haroon-Khel
Copy link
Contributor Author

Going to create some containers on dockerhost-osuosl-ubuntu2204-aarch64-1 ref #2991

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall but a few things - I'd block merging on the first of these in particular:

@github-actions github-actions bot added docker and removed docker labels Feb 14, 2024
@Haroon-Khel
Copy link
Contributor Author

Ive updated some of the dockerfiles but will udpate the rest as part of the Create templates for dockerfiles, removing the need to have a different file for each new release of OS issue of the epic #3368

@karianna karianna requested a review from sxa February 14, 2024 19:37
@sxa
Copy link
Member

sxa commented Feb 15, 2024

@karianna My original review still stands until there are comments added to the top of the two .yml files in the new deploy_container role.

@github-actions github-actions bot added docker and removed docker labels Feb 15, 2024
@Haroon-Khel
Copy link
Contributor Author

Is there any way we can incorporate #3345 into this somehow to give each one a unique hostname?

I would like to incorporate this in a separate pr, alongside the Automate creation of node in jenkins after deploying static container part of the #3368 epic.

@Haroon-Khel
Copy link
Contributor Author

Haroon-Khel commented Feb 15, 2024

The alpine311 and fedora35 dockerstatic checks are failing because I have replaced their dockerfiles with alpine319 and fedora39 respectively. I will update the workflow in a separate pr (once this one gets merged)

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Haroon-Khel Haroon-Khel merged commit 63d7307 into adoptium:master Feb 15, 2024
8 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants