-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker: New dockernode.yml playbook to automate deployment of docker static containers #3390
Conversation
The changes work
|
Going to create some containers on dockerhost-osuosl-ubuntu2204-aarch64-1 ref #2991 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall but a few things - I'd block merging on the first of these in particular:
- Can you add something into the top of each file to explain specifically what it does
- If we're going to test this on some systems for real deployments this week can we update some of the dockerfiles to use up to date OSs e.g. Fedora 39, Alpine 3.19 and Ubuntu 23.10 since a few of the ones we have just now are already out of support as per https://github.com/adoptium/infrastructure/wiki/End-of-support-date-for-OS-distributions?
- Is there any way we can incorporate Adjust docker run for StaticDocker images to use -
h
#3345 into this somehow to give each one a unique hostname?
Ive updated some of the dockerfiles but will udpate the rest as part of the |
@karianna My original review still stands until there are comments added to the top of the two |
The alpine311 and fedora35 dockerstatic checks are failing because I have replaced their dockerfiles with alpine319 and fedora39 respectively. I will update the workflow in a separate pr (once this one gets merged) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ref #3370
New playbook added
dockernode.yml
which will deploy any number of specified containers onto a chosen dockerhost machine. Example usage: (will add to docs)The
deploy
tag must be specified if the user wants to deploy a container. Thedocker_images
variable will contain a list of chosen OSs for which we have dockerfiles (error is handled when dockerfile does not exist).I am testing this at the moment in awx. Once successful we can remove the container build and deploy functionality in https://github.com/adoptium/infrastructure/blob/master/ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/DockerStatic/tasks/main.yml and leave the
dockerhost.yml
playbook for setting up dockerhost machines only, and use the newdockernode.yml
playbook for deploying containers