Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unixPB: add openjdk devkit installs for Linux on x64, ppc64le, aarch64 #3488

Merged
merged 9 commits into from
May 3, 2024

Conversation

sxa
Copy link
Member

@sxa sxa commented Mar 22, 2024

There are loads of issues with this but as a "starter for 10" it should be functional. Stuff to fix later:

  • As a minimum allow for other devkit names in the SHA sum variables since this is hard coded to one per architecture ... Or use GPG signatures since they're being created
  • Should we have more families for the install? Suse is currently excluded but we don't have any Suse build systems
  • We don't yet have a solution for s390x ...

Related:

Checklist

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

Signed-off-by: Stewart X Addison <sxa@redhat.com>
Signed-off-by: Stewart X Addison <sxa@redhat.com>
@sxa sxa marked this pull request as ready for review April 2, 2024 21:45
sxa added 2 commits April 2, 2024 23:31
Signed-off-by: Stewart X Addison <sxa@redhat.com>
Signed-off-by: Stewart X Addison <sxa@redhat.com>
@sxa
Copy link
Member Author

sxa commented Apr 2, 2024

New pushes because the bxx number has moved to a more sensible place, and there is now a top level directory in the tarball. Prebiously the filename was defined as:
devkit_filename: devkit-{{ devkit_version|replace('-b','-{{ ansible_architecture }}-linux-gnu-b') }}.tar.xz

sxa added 4 commits April 3, 2024 09:59
Signed-off-by: Stewart X Addison <sxa@redhat.com>
Signed-off-by: Stewart X Addison <sxa@redhat.com>
Signed-off-by: Stewart X Addison <sxa@redhat.com>
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@sxa sxa merged commit 8d4435e into adoptium:master May 3, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants