Provide a temurin-build build arg --use-adoptium-devkit <devkit_tag>

[andrew-m-leonard]

Enable users to build using an Adoptium built DevKit from https://github.com/adoptium/devkit-binaries
Adding a new build arg:

--use-adoptium-devkit <devkit_tag>

eg.:

--use-adoptium-devkit gcc-11.3.0-Centos7.6.1810-b01

This will download and verify the DevKit for the given architecture from the devkit-binaries release specified.
Then build using that devkit

[github-actions]

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

[andrew-m-leonard]

Currently based on PR https://github.com/adoptium/temurin-build/pull/3696/files
Will need rebasing once that is merged.

Also, cherry-picks fix: https://github.com/adoptium/temurin-build/pull/3701/files

[sxa]

Time for a controversial discussion starter ;-)

This is a follow-on to my recent comment in #3691 (review) since it's especially relevant here but I strongly believe it would be preferable to have these devkits installed into the Linux container build image as a default on the system - replacing the Adoptium/GCC11 installs we currently put on - for use going forward so they can be used by anyone using our images who are typically not using the make-adopt-build-farm.sh

We should make the end-user process as slick as possible for being to reproduce the Temurin builds. I know there has been some concern expressed relating to the provenance of these things if we don't download but that would also be true of anything else in these images such as make and anything else that is on these images. Plus the docker images are checksummed and therefore verifiable.

So TL;DR I'd really like to modify the playbooks to add the devkit in instead of downloading for each build and keep those on the images in parallel for a while with the Adoptium/GCC11 ones, then look at removing the Adoptium/GCC11 later, especially since the Adoptium/GCC11 ones will be redundant and so potentially lead to confusion if they are picked up.

Also there may be justification for a new type of build image that contains the minimal amount of packages to build Temurin 20+ plus the devkit (This could be really quite small based on the tests I've done - the devkit tarballs seem no larger then the previous gcc-only ones)

[andrew-m-leonard]

Yes agree, a follow on from this PR, would be to check if the requested devkit_tag (eg.gcc-11.3.0-Centos7.9.2009-b01) is already located in /usr/local/gcc11 (or whereever...), hence why I have added the tag to the devkit.info:
https://github.com/adoptium/ci-jenkins-pipelines/pull/955/files#diff-6f0823534c91127817b92b81710a0e3001e18d23eda57f34f4423a27daaece5dR45

Given the short runway for April, I want to get it functional downloading, before that next step.

no block on master branch now

[sxa]

Looks ok, but we perhaps need to have a bit of documentation somewhere on using the devkit and make it clear / throw a warning if the --with-devkit and --with-adoptium-devkit are both specified, since the latter will set the --with-devkit option to the appropriate location after download.

[andrew-m-leonard]

Looks ok, but we perhaps need to have a bit of documentation somewhere on using the devkit and make it clear / throw a warning if the --with-devkit and --with-adoptium-devkit are both specified, since the latter will set the --with-devkit option to the appropriate location after download.

thanks, i forgot to update the README.md, done...
I will do a blog about DevKits at some point

[steelhead31]

LGTM