-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Temurin build of x64/ppc64le/aarch64/s390x Linux for jdk-21+ using Adoptium gcc 11.3.0 DevKit #984
Enable Temurin build of x64/ppc64le/aarch64/s390x Linux for jdk-21+ using Adoptium gcc 11.3.0 DevKit #984
Conversation
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
run tests |
PR TESTER RESULT ✅ All pipelines passed! ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be able to add in a --with-devkit
parameter for s390x along with this too assuming some of my test runs overnight work as expected :-)
Also when adoptium/infrastructure#3488 goes in and the build images get built the same will be possible on these three platforms too.
@sxa That's great. Lets get this merged, and I can enable the later in a new PR. |
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Note to reviewers - the s390x naming WILL be improved later for consistency but this will allow us to get parity for now.
Enable Temurin build of x64/ppc64le/aarch64/s390x Linux for jdk-21+ using Adoptium DevKit
release:
aarch64 uses Centos7.6 as it is the matching latest version for RHEL7.