Remove NODE_LABEL from build job params #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Successful test with no NODE_LABEL: https://ci.adoptium.net/job/build-scripts/job/openjdk20-pipeline/207/console |
sxa
approved these changes
Jun 5, 2023
karianna
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes adoptium/ci-jenkins-pipelines#312
Issue https://github.com/adoptium/ci-jenkins-pipelines/pull/101/files originally remove the NODE_LABEL from the create build job template, as it is correctly not needed, since the openjdk pipelines use node() context to achieve the same here: https://github.com/adoptium/ci-jenkins-pipelines/blob/bc206dcf5aab5ebba3f081a55533c9313fc5cefb/pipelines/build/common/openjdk_build_pipeline.groovy
However the jenkins-helper IndividualBuildConfig.toBuildParams() was still adding it to the job invocation, thus causing the Jenkins log error...